Skip to content

Commit

Permalink
fix(injector: lineinfo): line directive without line number is ignored (
Browse files Browse the repository at this point in the history
#457)

Previously, line directives from the `<generated>` file would appear
without line number as `<generated>` because `<generated>:0` would make
the compiler fail with the error: ` invalid line number: 0`. But we
found out that `<generated>` is actually ignored by the go compiler.
This means that we have to set the line number to 1 and let it appear

Signed-off-by: Eliott Bouhana <[email protected]>
  • Loading branch information
eliottness authored Dec 9, 2024
1 parent 008e8f3 commit 5e5d184
Show file tree
Hide file tree
Showing 43 changed files with 147 additions and 147 deletions.
4 changes: 2 additions & 2 deletions internal/injector/builtin/testdata/client/aws.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/injector/builtin/testdata/client/aws_v2.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions internal/injector/builtin/testdata/client/elasticsearch.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/injector/builtin/testdata/client/gocql.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions internal/injector/builtin/testdata/client/gorm.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/injector/builtin/testdata/client/grpc.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions internal/injector/builtin/testdata/client/http.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/injector/builtin/testdata/client/ibm_sarama.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/injector/builtin/testdata/client/logrus.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions internal/injector/builtin/testdata/client/main.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions internal/injector/builtin/testdata/client/mongo.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/injector/builtin/testdata/client/pgx.go.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5e5d184

Please sign in to comment.