Remove metricType from runtime metric mapping definition #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a change from #19 that fixes a breaking issue when sent runtime metrics have the incorrect metric type. #19 has been delayed so I wanted to merge this change first to prevent potential issues.
When a runtime metric gets sent as a Gauge, but it's defined as a Sum in the
runtimeMetricsMappingsvariable, the metric will get sent to themapSumRuntimeMetricWithAttributesfunction. This will cause a runtime error because the function tries to callmd.Sum()whenmdis actually a Gauge. To avoid this, I decided to decouple the metric type from theruntimeMetricMappingand usemd.Type()instead. The metric type can be further specified in the metadata on our end.