[pkg/otlp/logs] Switch to Translator design #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
commented
Dec 19, 2023
|
The usage on the Agent would look like this https://github.com/DataDog/datadog-agent/blob/bca34b6e8668b8986486e74e2e88c33be81d34b1/comp/otelcol/otlp/internal/logsagentexporter/logs_exporter.go#L41-L68 |
dineshg13
reviewed
Dec 19, 2023
pkg/otlp/logs/logs_translator.go
Outdated
| @@ -15,251 +15,49 @@ | |||
| package logs | |||
There was a problem hiding this comment.
Can u rename the file to translator.go ?
dineshg13
approved these changes
Dec 19, 2023
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 21, 2023
**Description:**
- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
- Refactor related to upcoming metric:
- DataDog/opentelemetry-mapping-go/pull/230
- DataDog/opentelemetry-mapping-go/pull/231
- DataDog/opentelemetry-mapping-go/pull/229
- Host metadata updates:
- DataDog/opentelemetry-mapping-go/pull/184
- DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in #29785, since it's no longer true that we add this metric.
10 tasks
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…y#30158) **Description:** - [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes: - Refactor related to upcoming metric: - DataDog/opentelemetry-mapping-go/pull/230 - DataDog/opentelemetry-mapping-go/pull/231 - DataDog/opentelemetry-mapping-go/pull/229 - Host metadata updates: - DataDog/opentelemetry-mapping-go/pull/184 - DataDog/opentelemetry-mapping-go/pull/225 - Use `logs.Translator` for logs implementation - Set `MeterProvider` to noop to prevent sending metrics for now until we agree on the design. Note that I reverted one of the changelog items added in open-telemetry#29785, since it's no longer true that we add this metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move to a
Translatorstruct design for logs. This is part of the refactor for accomplishing #222, I need to do this so that:logs.TranslatorSourceFromAttrsonce per log record, we can just call it once per resource.Motivation