Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/inframetadata] Add support for host.cpu attributes #174

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 10, 2023

What does this PR do?

Adds support for upcoming CPU resource attributes defined by open-telemetry/semantic-conventions/pull/209.

Motivation

OpenTelemetry customers have this information available for all hosts.

@mx-psi mx-psi marked this pull request as ready for review October 10, 2023 13:51
@mx-psi mx-psi requested a review from a team as a code owner October 10, 2023 13:51
@mx-psi mx-psi requested a review from gbbr October 10, 2023 13:51
@mx-psi mx-psi merged commit 89962e6 into main Oct 26, 2023
6 checks passed
@mx-psi mx-psi deleted the mx-psi/cpu-model branch October 26, 2023 15:50
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this pull request Nov 13, 2023
This PR updates `github.com/DataDog/datadog-agent/pkg/trace` and `github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes`. This brings in the following PRs: DataDog/opentelemetry-mapping-go#193, DataDog/opentelemetry-mapping-go#174 which add support for custom container tags (for traces, metrics and logs) via resource attributes prefixed by `datadog.container.tag.*`.

This PR also brings a couple other changes for traces which are reflected in the changelog:
- Stop extracting container tags from span attributes, but only extract from resource attributes. The semantic conventions we are using to extract the container tags are meant for resource attributes, so we should only check resource attributes.
- Stop setting the DD Format container tags as span tags, but only set these in the dedicated container tag (_dd.container.tag). We currently set the DD mapped container tags both as span tag, and in the dedicated container tag `_dd.tags.container`. This should only be set in the dedicated container tag.

The update to opentelemetry-mapping-go also brings in this change: DataDog/opentelemetry-mapping-go#174, which adds support for `host.cpu.*` attributes.
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this pull request Nov 13, 2023
…-telemetry#29154

This PR updates `github.com/DataDog/datadog-agent/pkg/trace` and `github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes`. This brings in the following PRs: DataDog/opentelemetry-mapping-go#193, DataDog/opentelemetry-mapping-go#174 which add support for custom container tags (for traces, metrics and logs) via resource attributes prefixed by `datadog.container.tag.*`.

This PR also brings a couple other changes for traces which are reflected in the changelog:
- Stop extracting container tags from span attributes, but only extract from resource attributes. The semantic conventions we are using to extract the container tags are meant for resource attributes, so we should only check resource attributes.
- Stop setting the DD Format container tags as span tags, but only set these in the dedicated container tag (`_dd.container.tag`). We currently set the DD mapped container tags both as span tag, and in the dedicated container tag `_dd.tags.container`. This should only be set in the dedicated container tag.

The update to opentelemetry-mapping-go also brings in this change: DataDog/opentelemetry-mapping-go#174, which adds support for `host.cpu.*` attributes.
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 14, 2023
)

**Description:**
This PR updates `github.com/DataDog/datadog-agent/pkg/trace` and
`github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes`. This
brings in the following PRs:
DataDog/opentelemetry-mapping-go#193,
DataDog/datadog-agent#20779 which add support
for custom container tags (for traces, metrics and logs) via resource
attributes prefixed by `datadog.container.tag.*`.

This PR also brings a couple other changes for traces which are
reflected in the changelog:
- Stop extracting container tags from span attributes, but only extract
from resource attributes. The semantic conventions we are using to
extract the container tags are meant for resource attributes, so we
should only check resource attributes.
- Stop setting the DD Format container tags as span tags, but only set
these in the dedicated container tag (`_dd.container.tag`). We currently
set the DD mapped container tags both as span tag, and in the dedicated
container tag `_dd.tags.container`. This should only be set in the
dedicated container tag.

The update to opentelemetry-mapping-go also brings in this change:
DataDog/opentelemetry-mapping-go#174, which adds
support for `host.cpu.*` attributes.
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…n-telemetry#29156)

**Description:**
This PR updates `github.com/DataDog/datadog-agent/pkg/trace` and
`github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes`. This
brings in the following PRs:
DataDog/opentelemetry-mapping-go#193,
DataDog/datadog-agent#20779 which add support
for custom container tags (for traces, metrics and logs) via resource
attributes prefixed by `datadog.container.tag.*`.

This PR also brings a couple other changes for traces which are
reflected in the changelog:
- Stop extracting container tags from span attributes, but only extract
from resource attributes. The semantic conventions we are using to
extract the container tags are meant for resource attributes, so we
should only check resource attributes.
- Stop setting the DD Format container tags as span tags, but only set
these in the dedicated container tag (`_dd.container.tag`). We currently
set the DD mapped container tags both as span tag, and in the dedicated
container tag `_dd.tags.container`. This should only be set in the
dedicated container tag.

The update to opentelemetry-mapping-go also brings in this change:
DataDog/opentelemetry-mapping-go#174, which adds
support for `host.cpu.*` attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants