[otlp] update protobuf definitions to new location/version in datadog-agent repo #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit acf722d.
|
The relevant https://github.com/DataDog/datadog-agent branch has been merged with PR DataDog/datadog-agent#10650, so I've gone ahead and pushed the update to |
songy23
approved these changes
Jul 21, 2023
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 26, 2023
…g changes (#24552) **Description:** Upgrade dependency versions of `github.com/DataDog/opentelemetry-mapping-go` and `github.com/DataDog/datadog-agent` and fix breaking changes in protobuf (context: DataDog/datadog-agent#10650, DataDog/opentelemetry-mapping-go#126).
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 7, 2023
…g changes (#24674) **Description:** Roll forward #24552 with stable versions of dependencies. > Upgrade dependency versions of github.com/DataDog/opentelemetry-mapping-go and github.com/DataDog/datadog-agent and fix breaking changes in protobuf (context: DataDog/datadog-agent#10650, DataDog/opentelemetry-mapping-go#126).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reopens #103
This PR updates the protobuf imports such that the new definitions in pkg/proto in the agent repository are used. This includes some changes due to the gogoproto nullable type being removed from the definitions.
Additionally, due to a chicken-egg problem, these changes are currently pointing to a WIP PR on the datadog-agent repository (PR to be posted soon). Unfortunately the current protobuf structure (definitions part of https://github.com/DataDog/datadog-agent) doesn't make it easy to make these updates.
Motivation
Refactor of protobuf definitions in https://github.com/DataDog/datadog-agent so that all definitions now live in pkg/proto as opposed to scattered all over the repository.
PLEASE DO NOT MERGE, until the datadog-agent counterpart is merged: DataDog/datadog-agent#10650. At that point we can update relevant references.