Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for millisecond in Datadog logs timestamp #152

Closed
dougramirez opened this issue Aug 9, 2023 · 2 comments
Closed

Allow for millisecond in Datadog logs timestamp #152

dougramirez opened this issue Aug 9, 2023 · 2 comments

Comments

@dougramirez
Copy link

When the @timestamp additional property is set and sent to Datadog milli and nanoseconds are suppressed. Would it be possible to change the formatting of the field to:

lr.Timestamp().AsTime().Format(time.RFC3339Nano)

Instead of:

lr.Timestamp().AsTime().Format(time.RFC3339)

opentelemetry-mapping-go/pkg/otlp/logs/logs_translator.go

Line 159 in 1c4a596

l.AdditionalProperties[ddTimestamp] = lr.Timestamp().AsTime().Format(time.RFC3339)

@canadianveggie canadianveggie mentioned this issue Aug 9, 2023
Closed
@songy23
Copy link
Member

songy23 commented Aug 10, 2023

Chatted offline, as of now Datadog backend doesn’t support nanosecond, but we can look into setting millisecond precision in logs.

@songy23 songy23 changed the title Allow for nanoseconds in Datadog timestamp Allow for millisecond in Datadog logs timestamp Aug 10, 2023
ladenedge added a commit to ladenedge/opentelemetry-mapping-go that referenced this issue Nov 20, 2023
@ladenedge
Include milliseconds in DataDog timestamp format [Refs DataDog#152]
e5a804b
@ladenedge ladenedge mentioned this issue Nov 20, 2023
Merged
ladenedge added a commit to ladenedge/opentelemetry-mapping-go that referenced this issue Nov 23, 2023
@ladenedge
Added changelog information [Refs DataDog#152]
459063f
ladenedge added a commit to ladenedge/opentelemetry-mapping-go that referenced this issue Nov 28, 2023
@ladenedge
Added timezone to format string, fixed changelog. [Refs DataDog#152]
e37a4d1
ladenedge added a commit to ladenedge/opentelemetry-mapping-go that referenced this issue Dec 5, 2023
@ladenedge
Resolved conflict with new tests. [Refs DataDog#152]
d2d9698
liustanley pushed a commit that referenced this issue Dec 5, 2023
@ladenedge
Include milliseconds in DataDog timestamp format [Refs #152] (#202)
97610b4 
* Include milliseconds in DataDog timestamp format [Refs #152]

* Added changelog information [Refs #152]

* Added timezone to format string, fixed changelog. [Refs #152]

* Resolved conflict with new tests. [Refs #152]
@songy23
Copy link
Member

songy23 commented Dec 18, 2023

Fixed in #202.

@songy23 songy23 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougramirez @songy23