Deploy demo to ng-5 (gateway) #18
Conversation
mackjmr
force-pushed
the
mackjmr/add-gateway-deploy-staging
branch
from
4c228c0
to
3864631
Compare
mackjmr
force-pushed
the
mackjmr/add-gateway-deploy-staging
branch
from
c4f9cf6
to
33cfac4
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
@dineshg13 PR to deploy demo to gateway is ready, can you please take a look ?
There was a problem hiding this comment.
@mx-psi also adding you as a reviewer for this part:
It does not add datadog.host.name as mentioned in the doc, as k8s.pod.ip is already being added, so the k8sattributes processor is able to extract the hostname using this.
In a gateway setup in kubernetes, I don't think that adding datadog.host.name is necessary ?
For reference, here is the config to collector in gateway deploy: DataDog/opentelemetry-collector-contrib#4351 (only changes compared to daemonset is the nodegroup)
Also adding a link to the infrastructure list for env:otel-gateway in OpenTelemetry org: LINK. We can see the 3 nodes from the nodegroup for gateway: link.
There was a problem hiding this comment.
@mx-psi also adding you as a reviewer for this part:
It does not add datadog.host.name as mentioned in the doc, as k8s.pod.ip is already being added, so the k8sattributes processor is able to extract the hostname using this.
In a gateway setup in kubernetes, I don't think that adding
datadog.host.nameis necessary ?
Either way will work fine. I have a preference for the k8s.pod.ip approach because it means less manual work and less room for error.
This PR deploys the demo to the gateway namespace (ng-5). It does not add
datadog.host.nameas mentioned in the doc, ask8s.pod.ipis already being added, so the k8sattributes processor is able to extract the hostname using this.