Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-1018] Improve host metadata resource attributes #5248

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 10, 2024

Description:

  • Enable optional system detector attributes
  • Enable optional hostmetrics receiver metrics
  • Set datadog.host.use_as_metadata to true
  • Set an optional host tag

mx-psi and others added 2 commits January 10, 2024 13:48
- Enable optional system detector attributes
- Enable optional hostmetrics receiver metrics
- Set datadog.host.use_as_metadata to true
- Set an optional host tag
Not released just yet
@mx-psi mx-psi marked this pull request as ready for review January 10, 2024 13:01
@mx-psi mx-psi requested a review from mackjmr January 10, 2024 13:01
@mackjmr
Copy link
Member

mackjmr commented Jan 10, 2024

Just want to make sure that you want this enabled in all setups (even the non gateway ones) ? If you only want this enabled for the gateway setups, then you should just update the *-gateway.yaml files

@mx-psi
Copy link
Member Author

mx-psi commented Jan 10, 2024

Just want to make sure that you want this enabled in all setups (even the non gateway ones) ? If you only want this enabled for the gateway setups, then you should just update the *-gateway.yaml files

This is intentional, I thought about it for a bit and decided this made more sense since we are eventually going to promote this as the default way of getting host metadata in all types of deployments

ci/values.yaml Outdated Show resolved Hide resolved
@mx-psi mx-psi merged commit cb43d7c into prod Jan 12, 2024
89 checks passed
@mx-psi mx-psi deleted the mx-psi/gateway-attributes-staging branch January 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants