Skip to content

Commit

Permalink
Fix use pipeline ID
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinFairise2 committed Aug 1, 2024
1 parent 1e4056c commit afd065c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions e2e-tests/otel-collector/helm/otel_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ imagePullSecrets:

return components.NewComponent(e, resourceName, func(comp *otelcomp.OtelCollector) error {

_, err := helm.NewInstallation(e, helm.InstallArgs{
release, err := helm.NewInstallation(e, helm.InstallArgs{
RepoURL: "https://open-telemetry.github.io/opentelemetry-helm-charts",
ChartName: "opentelemetry-collector",
Namespace: "default",
Expand All @@ -57,7 +57,7 @@ imagePullSecrets:
}, pulumiResourceOpts...)

comp.LabelSelectors = pulumi.Map{
"app.kubernetes.io/name": pulumi.String("otel-collector"),
"app.kubernetes.io/name": release.Name,
}

return err
Expand Down
9 changes: 7 additions & 2 deletions e2e-tests/otel-collector/provisioner.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ func RunFunc(ctx *pulumi.Context, env *Kubernetes, params *ProvisionerParams) er
}
fi.Export(ctx, &env.FakeIntake.FakeintakeOutput)

otelCollector, err := helm.NewOtelCollector(&awsEnv, "otel-collector", otelparams.WithPulumiResourceOptions(pulumi.Provider(kubeProvider)), otelparams.WithFakeintake(fi))
otelOptions := []otelparams.Option{otelparams.WithPulumiResourceOptions(pulumi.Provider(kubeProvider)), otelparams.WithFakeintake(fi)}
otelOptions = append(otelOptions, params.otelOptions...)
otelCollector, err := helm.NewOtelCollector(&awsEnv, "otel-collector", otelOptions...)
if err != nil {
return err
}
Expand Down Expand Up @@ -155,7 +157,10 @@ func LocalRunFunc(ctx *pulumi.Context, env *Kubernetes, params *ProvisionerParam
}
fakeintake.Export(ctx, &env.FakeIntake.FakeintakeOutput)

otelCollector, err := helm.NewOtelCollector(&localEnv, "otel-collector", otelparams.WithPulumiResourceOptions(pulumi.Provider(kubeProvider)), otelparams.WithFakeintake(fakeintake))
otelOptions := []otelparams.Option{otelparams.WithPulumiResourceOptions(pulumi.Provider(kubeProvider)), otelparams.WithFakeintake(fakeintake)}
otelOptions = append(otelOptions, params.otelOptions...)

otelCollector, err := helm.NewOtelCollector(&localEnv, "otel-collector", otelOptions...)
if err != nil {
return err
}
Expand Down

0 comments on commit afd065c

Please sign in to comment.