Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rule precedence #353

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

[WIP] Rule precedence #353

wants to merge 17 commits into from

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Oct 28, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 85.58952% with 33 lines in your changes missing coverage. Please review.

Project coverage is 84.73%. Comparing base (eb80490) to head (37f9bb4).

Files with missing lines Patch % Lines
src/module_category.hpp 28.57% 5 Missing and 5 partials ⚠️
src/module.cpp 88.57% 6 Missing and 2 partials ⚠️
src/ruleset.hpp 33.33% 0 Missing and 6 partials ⚠️
src/clock.hpp 66.66% 0 Missing and 3 partials ⚠️
src/context.hpp 50.00% 0 Missing and 2 partials ⚠️
src/rule.hpp 87.50% 0 Missing and 2 partials ⚠️
src/builder/module_builder.cpp 96.96% 1 Missing ⚠️
src/context.cpp 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   84.68%   84.73%   +0.04%     
==========================================
  Files         153      157       +4     
  Lines        7889     7983      +94     
  Branches     3520     3554      +34     
==========================================
+ Hits         6681     6764      +83     
- Misses        460      466       +6     
- Partials      748      753       +5     
Flag Coverage Δ
waf_test 84.73% <85.58%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Oct 28, 2024

Benchmarks

Benchmark execution time: 2024-11-24 21:51:04

Comparing candidate commit 37f9bb4 in PR branch anilm3/rule-precedence with baseline commit eb80490 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random

  • 🟩 execution_time [-9.356ms; -9.297ms] or [-3.151%; -3.131%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants