Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Organise collections into a single module #352

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Oct 26, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 84.04255% with 15 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (65e2d3d) to head (bfef43c).

Files with missing lines Patch % Lines
src/ruleset.hpp 33.33% 0 Missing and 8 partials ⚠️
src/module.hpp 93.33% 0 Missing and 3 partials ⚠️
src/rule.hpp 50.00% 0 Missing and 2 partials ⚠️
src/context.hpp 0.00% 0 Missing and 1 partial ⚠️
src/module.cpp 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   84.50%   84.55%   +0.04%     
==========================================
  Files         153      153              
  Lines        7841     7865      +24     
  Branches     3502     3505       +3     
==========================================
+ Hits         6626     6650      +24     
  Misses        466      466              
  Partials      749      749              
Flag Coverage Δ
waf_test 84.55% <84.04%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 27, 2024

Benchmarks

Benchmark execution time: 2024-11-14 10:10:54

Comparing candidate commit bfef43c in PR branch anilm3/wip/collection_module with baseline commit 65e2d3d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants