Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-10680] Use ELF virtual address instead of file offset #680

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

nsavoire
Copy link
Contributor

What does this PR do?

Use ELF virtual address instead of file offset for normarlized addresses.

Motivation

When computing normalized address, use elf virtual addresses instead of file offsets because file offset alone is not enough to perform symbolization with split debug information.

Additional Notes

file_offset should probably be renamed, this will be addressed in a later PR.

@nsavoire nsavoire requested a review from a team as a code owner October 16, 2024 11:09
@nsavoire nsavoire force-pushed the nsavoire/PROF-8355-compute_elf_virtual_address branch from ecbe4f6 to 1d8f916 Compare October 16, 2024 11:12
@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-10-17 11:18:46

Comparing candidate commit 3c0e636 in PR branch nsavoire/PROF-8355-compute_elf_virtual_address with baseline commit 2820fd0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.372µs 3.236µs ± 1.410µs 3.061µs ± 0.028µs 3.085µs 3.509µs 13.885µs 14.966µs 389.01% 7.526 57.121 43.45% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.041µs; 3.431µs] or [-6.037%; +6.037%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.366µs 142.479µs ± 0.484µs 142.471µs ± 0.213µs 142.673µs 143.033µs 143.454µs 147.075µs 3.23% 4.227 39.154 0.34% 0.034µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.412µs; 142.546µs] or [-0.047%; +0.047%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 79.010µs 79.188µs ± 0.181µs 79.157µs ± 0.043µs 79.205µs 79.345µs 79.564µs 81.374µs 2.80% 9.067 104.602 0.23% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [79.163µs; 79.213µs] or [-0.032%; +0.032%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.865ms 8.895ms ± 0.025ms 8.891ms ± 0.008ms 8.901ms 8.922ms 8.949ms 9.154ms 2.96% 6.380 58.806 0.28% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.892ms; 8.899ms] or [-0.039%; +0.039%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.013µs 2.014µs ± 0.002µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.016µs 2.042µs 1.40% 11.507 148.575 0.11% 0.000µs 1 200
credit_card/is_card_number/ throughput 489771362.775op/s 496559972.987op/s ± 516691.631op/s 496630542.815op/s ± 122923.381op/s 496748540.233op/s 496795498.965op/s 496822099.848op/s 496837090.660op/s 0.04% -11.450 147.550 0.10% 36535.616op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 117.640µs 118.717µs ± 0.458µs 118.644µs ± 0.258µs 118.971µs 119.398µs 120.399µs 120.793µs 1.81% 1.039 2.905 0.38% 0.032µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8278651.219op/s 8423518.076op/s ± 32377.743op/s 8428550.754op/s ± 18338.900op/s 8444869.150op/s 8466284.800op/s 8491800.505op/s 8500502.380op/s 0.85% -0.996 2.745 0.38% 2289.452op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 109.439µs 110.265µs ± 0.330µs 110.244µs ± 0.196µs 110.442µs 110.768µs 111.138µs 112.228µs 1.80% 1.130 5.613 0.30% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8910434.079op/s 9069151.367op/s ± 27085.811op/s 9070768.542op/s ± 16127.245op/s 9086775.335op/s 9111916.467op/s 9125132.627op/s 9137470.941op/s 0.74% -1.075 5.293 0.30% 1915.256op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.013µs 2.014µs ± 0.002µs 2.014µs ± 0.001µs 2.014µs 2.015µs 2.016µs 2.035µs 1.03% 9.961 121.920 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 491503891.056op/s 496545632.555op/s ± 402961.023op/s 496585896.970op/s ± 127974.688op/s 496715809.293op/s 496806482.710op/s 496842519.765op/s 496893813.312op/s 0.06% -9.901 120.896 0.08% 28493.647op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 105.410µs 106.314µs ± 0.356µs 106.298µs ± 0.202µs 106.507µs 106.905µs 107.127µs 107.998µs 1.60% 0.542 1.917 0.33% 0.025µs 1 200
credit_card/is_card_number/378282246310005 throughput 9259394.631op/s 9406206.748op/s ± 31451.041op/s 9407489.570op/s ± 17924.304op/s 9424318.720op/s 9454528.174op/s 9475471.017op/s 9486806.698op/s 0.84% -0.506 1.805 0.33% 2223.924op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 103.742µs 104.904µs ± 0.536µs 104.889µs ± 0.379µs 105.284µs 105.818µs 106.018µs 106.625µs 1.66% 0.119 -0.294 0.51% 0.038µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9378660.792op/s 9532758.924op/s ± 48681.006op/s 9533924.726op/s ± 34503.766op/s 9567511.127op/s 9610921.996op/s 9633346.311op/s 9639307.167op/s 1.11% -0.093 -0.315 0.51% 3442.267op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 23.238µs 23.943µs ± 0.376µs 23.968µs ± 0.256µs 24.217µs 24.539µs 24.680µs 24.962µs 4.15% -0.074 -0.557 1.57% 0.027µs 1 200
credit_card/is_card_number/x371413321323331 throughput 40060420.314op/s 41776039.200op/s ± 657779.214op/s 41722038.449op/s ± 449813.973op/s 42179728.291op/s 43003181.501op/s 43023158.067op/s 43032949.959op/s 3.14% 0.141 -0.568 1.57% 46512.014op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.015µs 2.015µs 0.08% 0.046 -0.747 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 496172051.605op/s 496579769.308op/s ± 137179.307op/s 496552877.133op/s ± 101014.171op/s 496709089.735op/s 496782324.083op/s 496819932.752op/s 496848722.470op/s 0.06% -0.045 -0.749 0.03% 9700.042op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 97.141µs 98.019µs ± 0.411µs 98.028µs ± 0.279µs 98.284µs 98.706µs 99.044µs 99.277µs 1.27% 0.357 -0.257 0.42% 0.029µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10072806.835op/s 10202308.039op/s ± 42734.665op/s 10201159.438op/s ± 29063.453op/s 10233913.782op/s 10265190.126op/s 10279832.785op/s 10294283.584op/s 0.91% -0.337 -0.283 0.42% 3021.797op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 87.922µs 88.882µs ± 0.408µs 88.851µs ± 0.266µs 89.121µs 89.600µs 89.905µs 90.108µs 1.41% 0.349 0.106 0.46% 0.029µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11097779.590op/s 11251060.683op/s ± 51602.945op/s 11254805.205op/s ± 33782.034op/s 11288295.168op/s 11332243.462op/s 11353501.457op/s 11373677.546op/s 1.06% -0.322 0.081 0.46% 3648.879op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.016µs 2.016µs 0.08% 0.194 -0.494 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 496127309.165op/s 496541043.140op/s ± 154316.400op/s 496518346.353op/s ± 119069.423op/s 496686294.613op/s 496771202.304op/s 496797881.003op/s 496819405.196op/s 0.06% -0.192 -0.496 0.03% 10911.817op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 83.721µs 84.755µs ± 0.466µs 84.692µs ± 0.275µs 85.029µs 85.583µs 86.006µs 86.137µs 1.71% 0.467 0.118 0.55% 0.033µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11609377.504op/s 11799109.618op/s ± 64684.756op/s 11807472.953op/s ± 38308.643op/s 11840445.486op/s 11900121.476op/s 11919572.440op/s 11944504.617op/s 1.16% -0.436 0.082 0.55% 4573.903op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 103.485µs 104.843µs ± 0.578µs 104.819µs ± 0.407µs 105.246µs 105.833µs 106.101µs 106.182µs 1.30% 0.098 -0.527 0.55% 0.041µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9417778.234op/s 9538363.548op/s ± 52592.639op/s 9540245.158op/s ± 37040.382op/s 9575983.911op/s 9625715.580op/s 9644406.836op/s 9663262.480op/s 1.29% -0.073 -0.533 0.55% 3718.861op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 23.241µs 23.919µs ± 0.401µs 23.914µs ± 0.262µs 24.166µs 24.566µs 24.785µs 25.034µs 4.68% 0.220 -0.559 1.67% 0.028µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 39945723.391op/s 41818911.000op/s ± 698418.370op/s 41816900.447op/s ± 462827.463op/s 42307211.169op/s 42991012.600op/s 43022071.908op/s 43026577.794op/s 2.89% -0.151 -0.611 1.67% 49385.637op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.014µs; 2.014µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ throughput [496488364.496op/s; 496631581.478op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [118.654µs; 118.780µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8419030.832op/s; 8428005.320op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [110.219µs; 110.311µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9065397.535op/s; 9072905.200op/s] or [-0.041%; +0.041%] None None None
credit_card/is_card_number/37828224631 execution_time [2.014µs; 2.014µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [496489786.033op/s; 496601479.078op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [106.265µs; 106.363µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/378282246310005 throughput [9401847.937op/s; 9410565.560op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [104.830µs; 104.978µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9526012.205op/s; 9539505.643op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/x371413321323331 execution_time [23.891µs; 23.995µs] or [-0.218%; +0.218%] None None None
credit_card/is_card_number/x371413321323331 throughput [41684877.327op/s; 41867201.073op/s] or [-0.218%; +0.218%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.014µs; 2.014µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [496560757.576op/s; 496598781.041op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [97.962µs; 98.076µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10196385.426op/s; 10208230.653op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [88.826µs; 88.939µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11243909.011op/s; 11258212.355op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.014µs; 2.014µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [496519656.371op/s; 496562429.908op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [84.690µs; 84.819µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11790144.933op/s; 11808074.303op/s] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [104.763µs; 104.923µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9531074.714op/s; 9545652.382op/s] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [23.864µs; 23.975µs] or [-0.232%; +0.232%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [41722116.931op/s; 41915705.069op/s] or [-0.231%; +0.231%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.627µs 2.684µs ± 0.016µs 2.682µs ± 0.005µs 2.689µs 2.719µs 2.735µs 2.735µs 1.98% 0.520 3.829 0.61% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.682µs; 2.687µs] or [-0.084%; +0.084%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.116µs 1.172µs ± 0.022µs 1.173µs ± 0.015µs 1.192µs 1.197µs 1.199µs 1.200µs 2.27% -0.898 0.121 1.90% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.169µs; 1.175µs] or [-0.264%; +0.264%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.641µs 24.525µs ± 10.390µs 19.359µs ± 0.367µs 30.466µs 39.011µs 43.376µs 100.143µs 417.30% 3.090 15.606 42.26% 0.735µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.085µs; 25.965µs] or [-5.871%; +5.871%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 622.695µs 623.984µs ± 0.600µs 623.995µs ± 0.385µs 624.345µs 624.998µs 625.260µs 625.614µs 0.26% 0.037 -0.385 0.10% 0.042µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1598428.790op/s 1602607.215op/s ± 1540.863op/s 1602576.210op/s ± 987.709op/s 1603704.054op/s 1605234.247op/s 1605787.690op/s 1605922.090op/s 0.21% -0.032 -0.387 0.10% 108.955op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 461.076µs 462.152µs ± 0.532µs 462.127µs ± 0.409µs 462.541µs 463.040µs 463.210µs 463.522µs 0.30% 0.164 -0.698 0.11% 0.038µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2157394.903op/s 2163792.326op/s ± 2492.598op/s 2163907.940op/s ± 1912.933op/s 2165707.206op/s 2167592.923op/s 2168586.496op/s 2168840.587op/s 0.23% -0.159 -0.700 0.11% 176.253op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.157µs 178.345µs ± 0.105µs 178.333µs ± 0.054µs 178.387µs 178.546µs 178.693µs 178.756µs 0.24% 0.986 1.559 0.06% 0.007µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5594207.894op/s 5607102.594op/s ± 3313.970op/s 5607473.312op/s ± 1713.302op/s 5609197.113op/s 5611692.940op/s 5612655.311op/s 5613016.723op/s 0.10% -0.982 1.546 0.06% 234.333op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.659µs 46.817µs ± 0.077µs 46.805µs ± 0.047µs 46.857µs 46.964µs 47.020µs 47.046µs 0.52% 0.647 0.136 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21255671.298op/s 21359652.011op/s ± 34988.220op/s 21365280.547op/s ± 21532.266op/s 21382407.263op/s 21408697.416op/s 21420593.892op/s 21432254.154op/s 0.31% -0.639 0.123 0.16% 2474.041op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.936µs 49.386µs ± 0.222µs 49.355µs ± 0.111µs 49.473µs 49.722µs 50.144µs 50.731µs 2.79% 1.876 7.437 0.45% 0.016µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19711704.856op/s 20249002.440op/s ± 90078.364op/s 20261486.260op/s ± 45544.543op/s 20302619.994op/s 20369203.900op/s 20402099.199op/s 20434654.608op/s 0.85% -1.798 6.938 0.44% 6369.502op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [623.901µs; 624.067µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1602393.666op/s; 1602820.764op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [462.078µs; 462.226µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2163446.876op/s; 2164137.776op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [178.331µs; 178.360µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5606643.310op/s; 5607561.878op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.807µs; 46.828µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21354802.980op/s; 21364501.042op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.355µs; 49.417µs] or [-0.062%; +0.062%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20236518.445op/s; 20261486.434op/s] or [-0.062%; +0.062%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.409µs 37.862µs ± 0.805µs 37.491µs ± 0.027µs 37.530µs 39.567µs 39.607µs 40.962µs 9.26% 1.766 1.430 2.12% 0.057µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.750µs; 37.974µs] or [-0.295%; +0.295%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 188.091µs 192.384µs ± 1.195µs 192.477µs ± 0.692µs 193.154µs 194.094µs 194.654µs 194.689µs 1.15% -0.787 0.932 0.62% 0.085µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5136405.354op/s 5198124.850op/s ± 32464.420op/s 5195418.146op/s ± 18620.634op/s 5215221.738op/s 5261770.767op/s 5290444.210op/s 5316585.901op/s 2.33% 0.831 1.028 0.62% 2295.581op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.193µs 18.224µs ± 0.026µs 18.229µs ± 0.023µs 18.243µs 18.265µs 18.296µs 18.340µs 0.61% 0.904 1.181 0.14% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54525778.217op/s 54871771.784op/s ± 77786.528op/s 54858180.008op/s ± 68600.964op/s 54941639.640op/s 54956324.628op/s 54963440.416op/s 54967424.813op/s 0.20% -0.894 1.133 0.14% 5500.338op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.292µs 11.355µs ± 0.030µs 11.348µs ± 0.013µs 11.368µs 11.401µs 11.435µs 11.587µs 2.11% 2.770 16.348 0.27% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 86301812.271op/s 88069614.774op/s ± 234172.431op/s 88122680.760op/s ± 100734.016op/s 88208428.246op/s 88341963.182op/s 88419195.921op/s 88561212.403op/s 0.50% -2.687 15.522 0.27% 16558.491op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [192.219µs; 192.550µs] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5193625.593op/s; 5202624.106op/s] or [-0.087%; +0.087%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.221µs; 18.228µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54860991.319op/s; 54882552.249op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.351µs; 11.359µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good throughput [88037160.727op/s; 88102068.821op/s] or [-0.037%; +0.037%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c0e636 1729163302 nsavoire/PROF-8355-compute_elf_virtual_address
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 256.218ns 270.412ns ± 16.145ns 262.787ns ± 5.175ns 278.230ns 303.630ns 327.552ns 330.074ns 25.61% 1.688 2.469 5.96% 1.142ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [268.174ns; 272.649ns] or [-0.827%; +0.827%] None None None

Baseline

Omitted due to size.

Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire nsavoire force-pushed the nsavoire/PROF-8355-compute_elf_virtual_address branch from 1d8f916 to 248e8bd Compare October 16, 2024 14:16
@nsavoire nsavoire changed the title Use ELF virtual address instead of file offset [PROF-10680] Use ELF virtual address instead of file offset Oct 16, 2024
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When computing normalized address, use elf virtual addresses instead of
file offsets because file offset alone is not enough to perform
symbolization with split debug information.
@nsavoire nsavoire force-pushed the nsavoire/PROF-8355-compute_elf_virtual_address branch from 248e8bd to 3c0e636 Compare October 17, 2024 11:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (2820fd0) to head (3c0e636).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   71.81%   71.80%   -0.02%     
==========================================
  Files         271      271              
  Lines       40979    40987       +8     
==========================================
+ Hits        29428    29429       +1     
- Misses      11551    11558       +7     
Components Coverage Δ
crashtracker 20.33% <0.00%> (-0.04%) ⬇️
crashtracker-ffi 9.07% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.92% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.73% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 88.86% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.65% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.09% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.07% <ø> (ø)

@nsavoire nsavoire merged commit e9a0af0 into main Oct 17, 2024
30 checks passed
@nsavoire nsavoire deleted the nsavoire/PROF-8355-compute_elf_virtual_address branch October 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants