-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for remote config in the appsec helper #657
Conversation
ea30e71
to
f2f3fd3
Compare
BenchmarksComparisonBenchmark execution time: 2024-10-03 09:17:24 Comparing candidate commit 8ea84ed in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
2d5acf6
to
0a22cc2
Compare
151b1db
to
8bc89bf
Compare
0a22cc2
to
6384442
Compare
a6c85ac
to
a274cd9
Compare
cd71b03
to
a70f928
Compare
a274cd9
to
cf0ecf1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 71.90% 71.83% -0.08%
==========================================
Files 271 271
Lines 40647 40704 +57
==========================================
+ Hits 29228 29239 +11
- Misses 11419 11465 +46
|
a6b675d
to
6d712b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are simple enough and look fine to me :-)
6d712b3
to
8ea84ed
Compare
Adds some ASM constants, some functions to work with RC shared memory paths (rather than only ConfigInvariants and Targets, which are more difficult to pass around), and an in-memory notification mechanism.
In support of DataDog/dd-trace-php#2864