Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for remote config in the appsec helper #657

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

cataphract
Copy link
Contributor

Adds some ASM constants, some functions to work with RC shared memory paths (rather than only ConfigInvariants and Targets, which are more difficult to pass around), and an in-memory notification mechanism.

In support of DataDog/dd-trace-php#2864

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-10-03 09:17:24

Comparing candidate commit 8ea84ed in PR branch glopes/helper-rc with baseline commit 6e8dbae in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 505.939µs 506.991µs ± 0.634µs 506.879µs ± 0.310µs 507.279µs 507.965µs 508.493µs 512.578µs 1.12% 3.800 28.973 0.12% 0.045µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1950922.144op/s 1972425.895op/s ± 2454.023op/s 1972858.801op/s ± 1205.430op/s 1973890.537op/s 1975040.553op/s 1976161.802op/s 1976522.172op/s 0.19% -3.739 28.252 0.12% 173.526op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 468.153µs 468.820µs ± 0.254µs 468.826µs ± 0.154µs 468.966µs 469.257µs 469.411µs 469.682µs 0.18% 0.225 0.113 0.05% 0.018µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2129099.637op/s 2133013.360op/s ± 1156.168op/s 2132988.583op/s ± 700.891op/s 2133783.090op/s 2134821.938op/s 2135276.066op/s 2136055.012op/s 0.14% -0.221 0.110 0.05% 81.753op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 180.392µs 180.797µs ± 0.155µs 180.801µs ± 0.093µs 180.892µs 181.056µs 181.167µs 181.299µs 0.28% 0.256 0.155 0.09% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5515741.320op/s 5531082.330op/s ± 4736.627op/s 5530955.545op/s ± 2835.712op/s 5534024.228op/s 5538383.752op/s 5540611.835op/s 5543486.829op/s 0.23% -0.250 0.149 0.09% 334.930op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.407µs 44.508µs ± 0.044µs 44.506µs ± 0.023µs 44.529µs 44.564µs 44.593µs 44.870µs 0.82% 2.701 21.671 0.10% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22286515.443op/s 22467763.966op/s ± 22121.601op/s 22468732.326op/s ± 11602.582op/s 22480184.523op/s 22496821.539op/s 22515298.070op/s 22519199.192op/s 0.22% -2.653 21.195 0.10% 1564.233op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.021µs 49.178µs ± 0.054µs 49.177µs ± 0.033µs 49.211µs 49.267µs 49.310µs 49.331µs 0.31% -0.144 0.404 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20271247.308op/s 20334374.951op/s ± 22199.830op/s 20334605.941op/s ± 13461.315op/s 20347914.291op/s 20370827.835op/s 20397346.383op/s 20399323.558op/s 0.32% 0.152 0.407 0.11% 1569.765op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [506.903µs; 507.079µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1972085.791op/s; 1972765.999op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.785µs; 468.856µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2132853.126op/s; 2133173.594op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.775µs; 180.818µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5530425.879op/s; 5531738.781op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.502µs; 44.514µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22464698.125op/s; 22470829.808op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.170µs; 49.185µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20331298.268op/s; 20337451.634op/s] or [-0.015%; +0.015%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.647µs 139.645µs ± 0.411µs 139.621µs ± 0.181µs 139.781µs 140.352µs 140.519µs 142.595µs 2.13% 3.265 20.126 0.29% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.588µs; 139.702µs] or [-0.041%; +0.041%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.013µs 2.015µs ± 0.002µs 2.014µs ± 0.001µs 2.015µs 2.016µs 2.016µs 2.039µs 1.22% 11.096 141.474 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 490445305.569op/s 496400333.846op/s ± 458753.357op/s 496412780.275op/s ± 153809.305op/s 496588032.644op/s 496634809.036op/s 496662190.505op/s 496680891.181op/s 0.05% -11.039 140.474 0.09% 32438.761op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 123.982µs 125.648µs ± 0.556µs 125.650µs ± 0.355µs 126.016µs 126.488µs 127.028µs 127.108µs 1.16% -0.176 0.523 0.44% 0.039µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 7867314.592op/s 7958918.536op/s ± 35244.513op/s 7958641.732op/s ± 22500.162op/s 7980104.806op/s 8019593.384op/s 8054941.204op/s 8065657.680op/s 1.34% 0.210 0.548 0.44% 2492.163op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 114.420µs 116.835µs ± 0.646µs 116.910µs ± 0.360µs 117.226µs 117.683µs 118.411µs 119.304µs 2.05% -0.167 1.851 0.55% 0.046µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8381940.466op/s 8559372.221op/s ± 47394.066op/s 8553554.626op/s ± 26315.421op/s 8584568.830op/s 8639837.222op/s 8675565.450op/s 8739729.040op/s 2.18% 0.230 1.840 0.55% 3351.267op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.013µs 2.015µs ± 0.003µs 2.014µs ± 0.001µs 2.015µs 2.016µs 2.024µs 2.038µs 1.20% 7.832 67.395 0.13% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 490559956.653op/s 496350069.030op/s ± 635017.354op/s 496435910.126op/s ± 141450.475op/s 496581091.693op/s 496645810.244op/s 496681951.988op/s 496698679.472op/s 0.05% -7.801 66.986 0.13% 44902.508op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 110.686µs 113.092µs ± 0.711µs 113.143µs ± 0.429µs 113.507µs 114.141µs 114.440µs 114.674µs 1.35% -0.784 1.405 0.63% 0.050µs 1 200
credit_card/is_card_number/378282246310005 throughput 8720397.313op/s 8842690.532op/s ± 55846.117op/s 8838402.522op/s ± 33370.509op/s 8874744.083op/s 8943481.286op/s 9015741.802op/s 9034554.328op/s 2.22% 0.837 1.524 0.63% 3948.917op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 112.942µs 113.449µs ± 0.370µs 113.396µs ± 0.244µs 113.675µs 114.142µs 114.423µs 115.118µs 1.52% 1.037 1.312 0.33% 0.026µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 8686767.652op/s 8814595.454op/s ± 28650.137op/s 8818623.506op/s ± 19013.269op/s 8837229.819op/s 8849782.793op/s 8853049.851op/s 8854096.820op/s 0.40% -1.015 1.219 0.32% 2025.871op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 23.259µs 24.055µs ± 0.388µs 24.018µs ± 0.295µs 24.341µs 24.718µs 24.955µs 25.008µs 4.12% 0.221 -0.627 1.61% 0.027µs 1 200
credit_card/is_card_number/x371413321323331 throughput 39986926.014op/s 41582996.150op/s ± 669400.160op/s 41635368.638op/s ± 511812.930op/s 42094602.095op/s 42598792.786op/s 42935301.107op/s 42993770.473op/s 3.26% -0.158 -0.666 1.61% 47333.739op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.015µs 2.015µs 2.016µs 2.016µs 0.09% 0.231 -0.495 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 495964358.493op/s 496432427.331op/s ± 147159.085op/s 496406477.055op/s ± 123215.421op/s 496579899.706op/s 496636741.477op/s 496664519.646op/s 496703797.568op/s 0.06% -0.230 -0.498 0.03% 10405.719op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 97.482µs 98.469µs ± 0.459µs 98.455µs ± 0.328µs 98.734µs 99.222µs 99.645µs 100.005µs 1.57% 0.535 0.018 0.47% 0.032µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 9999506.887op/s 10155689.741op/s ± 47258.935op/s 10156886.663op/s ± 33950.755op/s 10195444.678op/s 10225192.116op/s 10239076.130op/s 10258281.400op/s 1.00% -0.511 -0.027 0.46% 3341.711op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 89.229µs 90.307µs ± 0.618µs 90.312µs ± 0.453µs 90.756µs 91.373µs 91.814µs 91.987µs 1.85% 0.379 -0.400 0.68% 0.044µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 10871133.292op/s 11073840.824op/s ± 75549.436op/s 11072720.145op/s ± 55268.402op/s 11131921.344op/s 11190509.964op/s 11200511.961op/s 11207067.843op/s 1.21% -0.349 -0.437 0.68% 5342.152op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.013µs 2.015µs ± 0.002µs 2.014µs ± 0.000µs 2.015µs 2.015µs 2.017µs 2.047µs 1.63% 12.524 166.918 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 488447791.621op/s 496386911.006op/s ± 586928.721op/s 496401960.613op/s ± 103879.487op/s 496571531.129op/s 496644096.326op/s 496682149.238op/s 496701213.662op/s 0.06% -12.480 166.121 0.12% 41502.128op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 85.186µs 86.327µs ± 0.454µs 86.306µs ± 0.266µs 86.591µs 87.117µs 87.530µs 88.023µs 1.99% 0.480 0.734 0.52% 0.032µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11360650.409op/s 11584136.297op/s ± 60756.187op/s 11586738.410op/s ± 35819.231op/s 11622281.368op/s 11677563.620op/s 11709994.014op/s 11738962.314op/s 1.31% -0.441 0.668 0.52% 4296.111op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 112.946µs 113.489µs ± 0.313µs 113.466µs ± 0.206µs 113.692µs 114.016µs 114.365µs 114.633µs 1.03% 0.686 0.547 0.27% 0.022µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 8723504.316op/s 8811506.328op/s ± 24226.234op/s 8813236.770op/s ± 15985.175op/s 8828789.851op/s 8846956.575op/s 8851171.219op/s 8853808.794op/s 0.46% -0.669 0.505 0.27% 1713.053op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 23.316µs 24.057µs ± 0.392µs 24.027µs ± 0.275µs 24.301µs 24.772µs 24.970µs 25.011µs 4.09% 0.418 -0.521 1.62% 0.028µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 39982222.397op/s 41579318.144op/s ± 672842.470op/s 41619166.541op/s ± 479957.159op/s 42108612.076op/s 42561436.957op/s 42736632.945op/s 42888852.193op/s 3.05% -0.355 -0.581 1.61% 47577.147op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.014µs; 2.015µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ throughput [496336755.043op/s; 496463912.650op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [125.571µs; 125.725µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [7954033.985op/s; 7963803.086op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [116.745µs; 116.924µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/ 378282246310005 throughput [8552803.859op/s; 8565940.583op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631 execution_time [2.014µs; 2.015µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631 throughput [496262061.732op/s; 496438076.328op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/378282246310005 execution_time [112.994µs; 113.191µs] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/378282246310005 throughput [8834950.797op/s; 8850430.267op/s] or [-0.088%; +0.088%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [113.398µs; 113.501µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [8810624.821op/s; 8818566.088op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number/x371413321323331 execution_time [24.001µs; 24.108µs] or [-0.224%; +0.224%] None None None
credit_card/is_card_number/x371413321323331 throughput [41490223.726op/s; 41675768.574op/s] or [-0.223%; +0.223%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.014µs; 2.014µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [496412032.497op/s; 496452822.165op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [98.405µs; 98.533µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10149140.107op/s; 10162239.375op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [90.221µs; 90.393µs] or [-0.095%; +0.095%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11063370.398op/s; 11084311.249op/s] or [-0.095%; +0.095%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.014µs; 2.015µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [496305568.331op/s; 496468253.682op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [86.264µs; 86.390µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11575716.074op/s; 11592556.520op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [113.446µs; 113.532µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [8808148.805op/s; 8814863.851op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [24.002µs; 24.111µs] or [-0.226%; +0.226%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [41486068.649op/s; 41672567.639op/s] or [-0.224%; +0.224%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.138µs 1.213µs ± 0.031µs 1.215µs ± 0.014µs 1.227µs 1.258µs 1.261µs 1.262µs 3.91% -0.498 0.025 2.59% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.209µs; 1.217µs] or [-0.360%; +0.360%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 290.777ns 301.454ns ± 14.687ns 294.164ns ± 2.781ns 305.787ns 331.916ns 353.975ns 355.727ns 20.93% 2.126 4.335 4.86% 1.039ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [299.419ns; 303.490ns] or [-0.675%; +0.675%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.941ms 8.978ms ± 0.014ms 8.978ms ± 0.010ms 8.988ms 9.001ms 9.010ms 9.013ms 0.38% -0.056 -0.239 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.976ms; 8.980ms] or [-0.022%; +0.022%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.268µs 28.601µs ± 11.563µs 21.493µs ± 2.492µs 35.790µs 44.659µs 47.542µs 112.107µs 421.60% 3.109 18.186 40.33% 0.818µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.998µs; 30.203µs] or [-5.603%; +5.603%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.507µs 3.221µs ± 1.587µs 3.059µs ± 0.031µs 3.089µs 3.190µs 13.904µs 18.472µs 503.81% 7.983 65.117 49.14% 0.112µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.001µs; 3.440µs] or [-6.828%; +6.828%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 270.063µs 271.549µs ± 0.752µs 271.471µs ± 0.521µs 272.006µs 273.030µs 273.568µs 273.645µs 0.80% 0.615 -0.106 0.28% 0.053µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3654364.371op/s 3682610.595op/s ± 10182.667op/s 3683628.850op/s ± 7086.044op/s 3690607.628op/s 3696798.314op/s 3699013.916op/s 3702842.450op/s 0.52% -0.603 -0.125 0.28% 720.023op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 26.541µs 26.602µs ± 0.058µs 26.580µs ± 0.024µs 26.626µs 26.723µs 26.751µs 26.785µs 0.77% 1.227 0.453 0.22% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37334806.445op/s 37591039.178op/s ± 81493.897op/s 37622770.419op/s ± 33371.821op/s 37650297.242op/s 37669406.384op/s 37674233.521op/s 37677463.469op/s 0.15% -1.221 0.434 0.22% 5762.489op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.096µs 16.121µs ± 0.029µs 16.104µs ± 0.006µs 16.140µs 16.154µs 16.181µs 16.386µs 1.75% 4.003 32.990 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 61028927.712op/s 62029186.677op/s ± 110364.582op/s 62097053.117op/s ± 24615.738op/s 62108781.494op/s 62119873.790op/s 62124161.554op/s 62127331.494op/s 0.05% -3.902 31.752 0.18% 7803.954op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [271.444µs; 271.653µs] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3681199.376op/s; 3684021.815op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [26.594µs; 26.610µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [37579744.908op/s; 37602333.448op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.117µs; 16.125µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/good throughput [62013891.207op/s; 62044482.146op/s] or [-0.025%; +0.025%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 75.095µs 75.303µs ± 0.146µs 75.287µs ± 0.035µs 75.326µs 75.417µs 75.522µs 77.042µs 2.33% 8.902 100.238 0.19% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [75.282µs; 75.323µs] or [-0.027%; +0.027%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.630µs 2.689µs ± 0.020µs 2.687µs ± 0.004µs 2.698µs 2.729µs 2.731µs 2.732µs 1.69% -0.655 2.506 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.686µs; 2.691µs] or [-0.101%; +0.101%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8ea84ed 1727946419 glopes/helper-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.438µs 38.838µs ± 0.552µs 38.608µs ± 0.045µs 38.678µs 39.925µs 39.964µs 41.996µs 8.78% 2.137 4.978 1.42% 0.039µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.762µs; 38.915µs] or [-0.197%; +0.197%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 11.47541% with 54 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (6e8dbae) to head (8ea84ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   71.90%   71.83%   -0.08%     
==========================================
  Files         271      271              
  Lines       40647    40704      +57     
==========================================
+ Hits        29228    29239      +11     
- Misses      11419    11465      +46     
Components Coverage Δ
crashtracker 20.36% <ø> (ø)
crashtracker-ffi 9.07% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.71% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.73% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 90.90% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <100.00%> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.07% <5.12%> (-0.28%) ⬇️
sidecar-ffi 0.00% <0.00%> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.66% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.36% <ø> (ø)

Base automatically changed from bob/live-debugger to main October 2, 2024 13:52
@cataphract cataphract force-pushed the glopes/helper-rc branch 3 times, most recently from a6b675d to 6d712b3 Compare October 2, 2024 15:30
Copy link
Contributor

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are simple enough and look fine to me :-)

@cataphract cataphract merged commit ebbb586 into main Oct 3, 2024
30 checks passed
@cataphract cataphract deleted the glopes/helper-rc branch October 3, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants