Ensure cgroup CPU poller works with multiple cgroups #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2024
GeorgeHahn
reviewed
Dec 13, 2024
GeorgeHahn
approved these changes
Dec 13, 2024
blt
changed the base branch from
blt/re-introduce_per-process_cpu_collection
to
graphite-base/1149
blt
force-pushed
the
graphite-base/1149
branch
from
b84ec4a to
9f09b9a
Compare
blt
force-pushed
the
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
branch
from
7bc3109 to
48ad9c8
Compare
blt
force-pushed
the
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
branch
from
48ad9c8 to
2d6266e
Compare
This commit corrects a similar bug to the one that I corrected in the stats reader, originally copied from this point. Specifically, we now store state that maintains the cgroup previous values needed to calculate diffs over time. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
branch
from
2d6266e to
9c62ec8
Compare
Merge activity
|
blt
deleted the
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit corrects a similar bug to the one that I corrected in
the stats reader, originally copied from this point. Specifically,
we now store state that maintains the cgroup previous values needed
to calculate diffs over time.