Adds path to metric labels for http blackhole #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blt
approved these changes
Dec 13, 2024
blt
added a commit
that referenced
this pull request
Dec 17, 2024
blt
added a commit
that referenced
this pull request
Dec 17, 2024
This release reverts PR #1148. Unfortunately duplicate tags on the metrics `bytes_received` causes errors in an analysis tool that is on a more strict release schedule than lading itself. We will have to re-introduce this change at a later date. Signed-off-by: Brian L. Troutwine <[email protected]>
Merged
blt
added a commit
that referenced
this pull request
Dec 17, 2024
This release reverts PR #1148. Unfortunately duplicate tags on the metrics `bytes_received` causes errors in an analysis tool that is on a more strict release schedule than lading itself. We will have to re-introduce this change at a later date. Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the HTTP
paththat a request was sent to for the metrics that give insight into the blackhole-received data.Motivation
Datadog agent sends to many different endpoints, we observe spikes that don't have a clearly understood destination, this will help.
Related issues
Additional Notes
I omit the
queryparameters, which should limit the cardinality of these metrics, but this is still a technically unbounded metric tag, which isn't ideal. I wasn't able to come up with any ideas to bound the cardinality here without making this feature significantly less useful (ie, only record up to 1/2/3 path segments)