Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZGC Cycles and ZGC Pauses beans support out of the box #393

Conversation

Kaderinho
Copy link
Contributor

@Kaderinho Kaderinho commented May 10, 2022

This PR adds OOTB support for ZGC beans.

There are some points that might be worth to discuss :

  • Metrics names :
    • concept of minor and major doesn't apply to ZGC, so using the same names doesn't make sense.
    • Nonetheless, using the same names will make thing easier for getting generic dashboard for instance
  • ZGC bean :
    • ZGC doesn't exist with Java 17 (see change log) but exists with JDK 14 as state in this PR (tested again and can confirm 👍). This is something we might want to write in documentation if not already here.
    • Also, what about the metrics names for ZGC ?
  • GC order :
    • I think it will be easier to check if some beans are missing or to add new beans in the file if we organize it by GC instead of by Old and Young Gen collectors, especially when ZGC breaks this logic. Not so important anyway.

@jpbempel
Copy link
Member

  • Metrics names :

    • concept of minor and major doesn't apply to ZGC, so using the same names doesn't make sense.

Yet, Generational ZGC is under active development and will be added in the future.
In the meantime, using major denomination is fine as it will reclaim the whole heap.

  • Nonetheless, using the same names will make thing easier for getting generic dashboard for instance

  • ZGC bean :

    • ZGC doesn't exist with Java 17 (see change log) but exists with JDK 14 as state in this PR (tested again and can confirm 👍). This is something we might want to write in documentation if not already here.

yes also with the change in semantic of CollectionTime (including only pauses first then including Concurrent Time after).

  • Also, what about the metrics names for ZGC ?

Fine by me.

Copy link
Member

@jpbempel jpbempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpbempel jpbempel mentioned this pull request May 18, 2022
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kaderinho Kaderinho merged commit 77cf696 into master Jun 22, 2022
@Kaderinho Kaderinho deleted the nicolas.guerguadj/support-more-garbage-collector-out-of-the-box branch June 22, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants