[log4j] migrate to log4j2 (#258) #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log via slf4j instead of directly to log4j
* [log4j] migrate to log4j2 * [travis] fix log4j config file directive * [log4j2] support STDERR and STDOUT as ways to refer to log location too
truthbk
force-pushed
the
jaime/log4j_agent5
branch
from
776565c to
6c24d91
Compare
prognant
reviewed
Jun 25, 2020
| } catch (IOException e) { | ||
| // Same as above | ||
| LOGGER.warn("Unable to replace $value for attribute " + fullAttributeName, e); | ||
| if (alias.contains("$value")) { |
Comment on lines
+66
to
+67
| && (ConsoleAppender.Target.SYSTEM_ERR.toString().equals(logLocation) | ||
| || SYSTEM_ERR_ALT.equals(logLocation))) { |
There was a problem hiding this comment.
Shouldn't we allow SYSTEM_OUT/ SYSTEM_OUT_ALT along with SYSTEM_ERR/ SYSTEM_ERR_ALT?
There was a problem hiding this comment.
Maybe.... but this is actually the same on master, most of these changes came in from cherry-pick'd logic. I had to fix a few things, but this is really the same everywhere. I don't oppose doing some follow-up and maybe verifying/fixing a couple of things in the logger logic, but this should be 👍 and consistent with our logging on JMXFetch on most recent versions.
Thanks for the review @prognant 🙇
truthbk
added a commit
that referenced
this pull request
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[log4j] migrate to log4j2
[travis] fix log4j config file directive
[log4j2] support STDERR and STDOUT as ways to refer to log location too