Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade java-dogstatsd-client to 2.7 #207

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Upgrade java-dogstatsd-client to 2.7 #207

merged 1 commit into from
Mar 1, 2019

Conversation

mattdrees
Copy link
Contributor

This PR upgrades java-dogstatsd-client from 2.1.0 to 2.7.

We'd like to take advantage of DataDog/java-dogstatsd-client#42, in particular.

@mattdrees
Copy link
Contributor Author

Rebased to resolve conflicts and match new style guide.

@mattdrees
Copy link
Contributor Author

@truthbk could I bother you to review this PR? It's not urgent, but I'm hoping it can be included in your next release, whenever that may be.

@mattdrees
Copy link
Contributor Author

This is our use case:
(copy/pasting from my support ticket response, because it might be helpful here)

We run a java application in a docker container orchestrated by AWS ECS. We'd like to collect metrics from it, as well as APM traces.

Your docs recommend using unix domain sockets for collecting metrics from containerized apps: https://docs.datadoghq.com/developers/dogstatsd/unix_socket/
Sounds like a good idea to us.

Your dd-trace-java library is needed for APM, and it also embeds JMXFetch so we can use it for metrics, without having to run it separately within the container (which would be a pain).
So using the embedded JMXFetch tool sounds great.

Unfortunately, JMXFetch doesn't support unix domain sockets, because it uses an older java-dogstatsd version. So we can't currently follow your recommendations. (Except by setting up socat, which works but requires another process to run inside my container.)

@mattdrees
Copy link
Contributor Author

@olivielpeau could I ask you to review?

@arbll arbll self-requested a review March 1, 2019 10:03
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mattdrees!

Adding UDS support in the context of dd-trace-java sounds very useful. I'll go ahead and merge this. Some wiring will probably be needed on dd-trace-java side. I'll sync up with the team responsible for it.

Thank you for the contribution!
Arthur

@arbll arbll merged commit 29dd95a into DataDog:master Mar 1, 2019
@arbll arbll added this to the 0.27.0 milestone Mar 1, 2019
@mattdrees
Copy link
Contributor Author

Thanks Arthur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants