Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where TabularData would not be returned if the metrics do not have tags #406

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

carlosroman
Copy link
Contributor

@carlosroman carlosroman commented Jan 30, 2023

This PR fixes an issue where TabularData was not correctly returned if the config had no mappings for tags.

i.e. The following config would work:

      - include:
          domain: org.datadog.jmxfetch.test
          attribute:
            Tabulardata.foo:
              metric_type: gauge
              alias: multiattr.foo
              tags:
                foo: $foo
                toto: $toto
              limit: 1
              sort: desc

But if you remove the tag section (like bellow) it would not return any data back.

      - include:
          domain: org.datadog.jmxfetch.test
          attribute:
            Tabulardata.foo:
              metric_type: gauge
              alias: multiattr.foo
              limit: 1
              sort: desc

@carlosroman carlosroman changed the title Fixed issue where TabularData would not be returned if the metrics ha… Fixed issue where TabularData would not be returned if the metrics do not have tags Jan 30, 2023
@carlosroman carlosroman merged commit 4071033 into master Feb 3, 2023
@carlosroman carlosroman deleted the carlosroman/AML-549-TabularData_fix branch February 3, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants