Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating JMXFetch to 0.47.3 #15447

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

carlosroman
Copy link
Contributor

What does this PR do?

This PR updates JMXFetch to 0.47.3 (previously 0.47.2).

Motivation

Version 0.47.3 fixes an bug where TabularData would not be returned if the metrics do not have tags, DataDog/jmxfetch#406.

Additional Notes

N/A

Possible Drawbacks / Trade-offs

None.

Describe how to test/QA your changes

Build the test JMXFetch test server from here. Add the config example to your conf.d directory and check the Agent is reporting metrics back. Make sure to check that jmx.test.tabular_data_foo is being sent correctly.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@carlosroman carlosroman force-pushed the carlosroman/jmxfetch-update-0.47.3 branch from 9d264b5 to 525d6c0 Compare February 6, 2023 17:40
@carlosroman carlosroman force-pushed the carlosroman/jmxfetch-update-0.47.3 branch from 525d6c0 to a257049 Compare February 7, 2023 10:41
@carlosroman carlosroman force-pushed the carlosroman/jmxfetch-update-0.47.3 branch from a257049 to 4f89d5f Compare February 8, 2023 08:45
@carlosroman carlosroman merged commit 42633e8 into main Feb 8, 2023
@carlosroman carlosroman deleted the carlosroman/jmxfetch-update-0.47.3 branch February 8, 2023 12:19
@carlosroman carlosroman mentioned this pull request Feb 14, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants