-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ZGC support #303
Initial ZGC support #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a high level, have you been able to confirm that this config actually collects the metrics with the right types @yafernandes?
Requesting a review from @prognant as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, double checked that ZGC bean names are correct.
@olivielpeau Yes, tested using |
@yafernandes @jpbempel need your help to understand what is the unit of the metric collected here for pause time? milliseconds? |
yes it's millisecond for CollectionTime |
thanks @jpbempel for quick revert. we upgraded our service to jdk17, but post that, we are not getting any gc metrics for pause or collection time anymore. we are on datadog agent |
See #393 |
@jpbempel if i understand correctly, the linked refrence says zgc support is not present in jdk17, should i updat3e to jdk18 in that case? |
no, it gives you a JMXFetch configuration to fetch metrics from new ZGC MBeans introduced in jdk17 |
Initial support for ZGC metrics.