Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ZGC support #303

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

yafernandes
Copy link
Contributor

Initial support for ZGC metrics.

Copy link
Member

@jpbempel jpbempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level, have you been able to confirm that this config actually collects the metrics with the right types @yafernandes?

Requesting a review from @prognant as well

@olivielpeau olivielpeau requested a review from prognant June 25, 2020 08:22
@jpbempel jpbempel mentioned this pull request Jun 25, 2020
Copy link
Contributor

@prognant prognant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, double checked that ZGC bean names are correct.

@yafernandes
Copy link
Contributor Author

@olivielpeau Yes, tested using OpenJDK Runtime Environment (build 14.0.1+7) on MacOS.

@vaibhavflip
Copy link

vaibhavflip commented May 12, 2022

@yafernandes @jpbempel need your help to understand what is the unit of the metric collected here for pause time? milliseconds?

@jpbempel
Copy link
Member

yes it's millisecond for CollectionTime
but regarding pause time, it depends on JDK version. for example it's pause time only for JDK14 but it includes concurrent time as well in JDK16.
for JDK17 they resolve the problem with separate MBeans: https://bugs.openjdk.java.net/browse/JDK-8265136
like in Shenandoah see #306

@vaibhavflip
Copy link

thanks @jpbempel for quick revert. we upgraded our service to jdk17, but post that, we are not getting any gc metrics for pause or collection time anymore. we are on datadog agent version 7 and using openjdk version 17.0.2-jdk-slim. please let me know if we need to do add/change something else as well

@jpbempel
Copy link
Member

See #393

@vaibhavflip
Copy link

@jpbempel if i understand correctly, the linked refrence says zgc support is not present in jdk17, should i updat3e to jdk18 in that case?

@jpbempel
Copy link
Member

no, it gives you a JMXFetch configuration to fetch metrics from new ZGC MBeans introduced in jdk17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants