Improve config name

Also fix Instance.toString()
DataDog · May 21, 2019 · 8e04526 · 8e04526
1 parent 89fca05
commit 8e04526
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 14 deletions.
diff --git a/src/main/java/org/datadog/jmxfetch/App.java b/src/main/java/org/datadog/jmxfetch/App.java
@@ -829,10 +829,10 @@ public void init(boolean forceNewConnection) {
             }
 
             for (LinkedHashMap<String, Object> configInstance : configInstances) {
-                if (appConfig.isAllowDirectInstances() != isDirectInstance(configInstance)) {
-                    log.debug("Skipping instance '{}'. allowDirectInstances={} jvm_direct={}",
+                if (appConfig.isTargetDirectInstances() != isDirectInstance(configInstance)) {
+                    log.debug("Skipping instance '{}'. targetDirectInstances={} jvm_direct={}",
                             name,
-                            appConfig.isAllowDirectInstances(),
+                            appConfig.isTargetDirectInstances(),
                             isDirectInstance(configInstance));
                     continue;
                 }

diff --git a/src/main/java/org/datadog/jmxfetch/AppConfig.java b/src/main/java/org/datadog/jmxfetch/AppConfig.java
@@ -1,8 +1,5 @@
 package org.datadog.jmxfetch;
 
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ImmutableMap;
-
 import com.beust.jcommander.Parameter;
 import com.beust.jcommander.Parameters;
 
@@ -12,7 +9,6 @@
 import org.datadog.jmxfetch.converter.ReporterConverter;
 import org.datadog.jmxfetch.reporter.ConsoleReporter;
 import org.datadog.jmxfetch.reporter.Reporter;
-import org.datadog.jmxfetch.reporter.ReporterFactory;
 import org.datadog.jmxfetch.validator.Log4JLevelValidator;
 import org.datadog.jmxfetch.validator.PositiveIntegerValidator;
 import org.datadog.jmxfetch.validator.ReporterValidator;
@@ -209,7 +205,7 @@ public class AppConfig {
      * If set to true, other instances will be ignored.
      */
     @Builder.Default
-    private boolean allowDirectInstances = false;
+    private boolean targetDirectInstances = false;
 
     // This is used by things like APM agent to provide configuration from resources
     private List<String> instanceConfigResources;
@@ -346,8 +342,8 @@ public String getJmxLaunchFile() {
         return getTmpDirectory() + "/" + AD_LAUNCH_FILE;
     }
 
-    public boolean isAllowDirectInstances() {
-        return allowDirectInstances;
+    public boolean isTargetDirectInstances() {
+        return targetDirectInstances;
     }
 
     public List<String> getInstanceConfigResources() {

diff --git a/src/main/java/org/datadog/jmxfetch/Instance.java b/src/main/java/org/datadog/jmxfetch/Instance.java
@@ -374,7 +374,9 @@ public void init(boolean forceNewConnection)
     /** Returns a string representation for the instance. */
     @Override
     public String toString() {
-        if (this.instanceMap.get(PROCESS_NAME_REGEX) != null) {
+        if (isDirectInstance(instanceMap)) {
+            return "jvm_direct";
+        } else if (this.instanceMap.get(PROCESS_NAME_REGEX) != null) {
             return "process_regex: `" + this.instanceMap.get(PROCESS_NAME_REGEX) + "`";
         } else if (this.instanceMap.get("jmx_url") != null) {
             return (String) this.instanceMap.get("jmx_url");

diff --git a/src/test/java/org/datadog/jmxfetch/TestApp.java b/src/test/java/org/datadog/jmxfetch/TestApp.java
@@ -491,7 +491,7 @@ public void testApp() throws Exception {
         registerMBean(testApp, "org.datadog.jmxfetch.test:type=SimpleTestJavaApp");
 
         // We do a first collection
-        when(appConfig.isAllowDirectInstances()).thenReturn(true);
+        when(appConfig.isTargetDirectInstances()).thenReturn(true);
         initApplication("jmx.yaml");
 
         run();

diff --git a/src/test/java/org/datadog/jmxfetch/TestServiceChecks.java b/src/test/java/org/datadog/jmxfetch/TestServiceChecks.java
@@ -20,7 +20,7 @@ public void testServiceCheckOK() throws Exception {
         registerMBean(new SimpleTestJavaApp(), "org.datadog.jmxfetch.test:type=ServiceCheckTest");
 
         // We do a first collection
-        when(appConfig.isAllowDirectInstances()).thenReturn(true);
+        when(appConfig.isTargetDirectInstances()).thenReturn(true);
         initApplication("jmx.yaml");
 
         run();
@@ -155,7 +155,7 @@ public void testServiceCheckCRITICAL() throws Exception {
 
     @Test
     public void testServiceCheckCounter() throws Exception {
-        when(appConfig.isAllowDirectInstances()).thenReturn(true);
+        when(appConfig.isTargetDirectInstances()).thenReturn(true);
         initApplication("jmx.yaml");
 
         Reporter repo = getReporter();