Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception for OK service checks with messages #9958

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Raise exception for OK service checks with messages #9958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21e6593
Add exception for good service check messages
yzhan289 Aug 13, 2021
b136293
Fix import
yzhan289 Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions datadog_checks_base/datadog_checks/base/stubs/aggregator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

from six import iteritems

from ..constants import ServiceCheck
from ..utils.common import ensure_unicode, to_native_string
from .common import HistogramBucketStub, MetricStub, ServiceCheckStub
from .similar import build_similar_elements_msg
Expand Down Expand Up @@ -123,6 +124,9 @@ def submit_metric_e2e(
self._metrics[name].append(MetricStub(name, mtype, value, tags, hostname, device))

def submit_service_check(self, check, check_id, name, status, tags, hostname, message):
if status == ServiceCheck.OK and message:
raise Exception("Expected empty message on OK service check")

check_tag_names(name, tags)
self._service_checks[name].append(ServiceCheckStub(check_id, name, status, tags, hostname, message))

Expand Down