Extend QueryManager query type
#9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7c33f22)
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
djmitche
previously approved these changes
Aug 11, 2021
Co-authored-by: Dustin J. Mitchell <[email protected]>
@djmitche The QueryManager may want to pass queries with additional context to the executor; in particular we want to use this for a future check (IBM i) where the executor also gets a timeout for each query. Existing users of QueryManager would keep getting just queries (strings) and would not need to support this.
Instead of doing this, we could pass the executor argument type as a new |
|
I think this is OK as-is. As you've said, it will allow for future support for mappings, and in the interim only increases the set of valid configs. Thanks for the explanation! |
ofek
requested changes
Aug 12, 2021
Co-authored-by: Ofek Lev <[email protected]>
mx-psi
force-pushed
the
mx-psi/backport-querymanager
branch
from
eb15705
to
6a88158
Compare
ofek
approved these changes
Aug 12, 2021
KSerrania
approved these changes
Aug 13, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2021
* Add 'timeout' field to QueryManager queries (cherry picked from commit 7c33f22) * Apply suggestions from code review Co-authored-by: Dustin J. Mitchell <[email protected]> * Address review comment Co-authored-by: Ofek Lev <[email protected]> Co-authored-by: Dustin J. Mitchell <[email protected]> Co-authored-by: Ofek Lev <[email protected]> 36dfad0
mx-psi
added a commit
that referenced
this pull request
Aug 13, 2021
Revert "Add 'timeout' field to QueryManager queries" This reverts commit 7c33f22. Extend `QueryManager` query type (#9874) * Add 'timeout' field to QueryManager queries (cherry picked from commit 7c33f22) * Apply suggestions from code review Co-authored-by: Dustin J. Mitchell <[email protected]> * Address review comment Co-authored-by: Ofek Lev <[email protected]> Co-authored-by: Dustin J. Mitchell <[email protected]> Co-authored-by: Ofek Lev <[email protected]> (cherry picked from commit 36dfad0)
mx-psi
added a commit
that referenced
this pull request
Aug 16, 2021
Revert "Add 'timeout' field to QueryManager queries" This reverts commit 7c33f22. Extend `QueryManager` query type (#9874) * Add 'timeout' field to QueryManager queries (cherry picked from commit 7c33f22) * Apply suggestions from code review Co-authored-by: Dustin J. Mitchell <[email protected]> * Address review comment Co-authored-by: Ofek Lev <[email protected]> Co-authored-by: Dustin J. Mitchell <[email protected]> Co-authored-by: Ofek Lev <[email protected]> (cherry picked from commit 36dfad0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends
QueryManagerquery type to allow mappings.Motivation
Needed for IBM i integration, see #9720.
Additional Notes
As of now it should be a no-op.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached