Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ksm] Fix statefulset tag #9832

Merged
merged 3 commits into from
Aug 4, 2021
Merged

[ksm] Fix statefulset tag #9832

merged 3 commits into from
Aug 4, 2021

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Fix tag reporting for statefulset metrics

Motivation

Better user experience with standardized tags

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

ahmed-mez
ahmed-mez previously approved these changes Aug 4, 2021
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #9832 (760ad51) into master (3ee898a) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
kubernetes_state 89.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@celenechang celenechang merged commit c120b20 into master Aug 4, 2021
@celenechang celenechang deleted the celene/fix_ksm_tags branch August 4, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants