Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log message for invalid queries #9797

Merged
merged 6 commits into from
Jul 29, 2021
Merged

Log message for invalid queries #9797

merged 6 commits into from
Jul 29, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Certain queries are not available on IBM Db2 versions <11.1. This PR makes sure to log a warning message but continue running other queries. This behavior is similar to the DB manager.

Motivation

Customer request

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

hithwen
hithwen previously approved these changes Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #9797 (c1cf93b) into master (f66e99f) will decrease coverage by 0.00%.
The diff coverage is 79.16%.

Flag Coverage Δ
ibm_db2 93.65% <79.16%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ChristineTChen ChristineTChen merged commit 19f3853 into master Jul 29, 2021
@ChristineTChen ChristineTChen deleted the cc/ibm-ver branch July 29, 2021 19:40
@hithwen hithwen mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants