-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extra 3rd party licenses #9796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
requested changes
Jul 28, 2021
Comment on lines
221
to
223
def get_extra_license_file(check_name): | ||
path = os.path.join(get_root(), check_name, 'LICENSE-3rdparty-extra.csv') | ||
return path, file_exists(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, wdyta:
Suggested change
def get_extra_license_file(check_name): | |
path = os.path.join(get_root(), check_name, 'LICENSE-3rdparty-extra.csv') | |
return path, file_exists(path) | |
def get_extra_license_files(): | |
for path in os.listdir(get_root()): | |
if not file_exists(get_manifest_file(path)): | |
continue | |
extra_license_file = os.path.join(get_root(), path, 'LICENSE-3rdparty-extra.csv') | |
if file_exists(extra_license_file): | |
yield extra_license_file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good- updated!
sarah-witt
changed the title
Allow for extra 3rd party licenses
Allow extra 3rd party licenses
Jul 28, 2021
ofek
approved these changes
Jul 28, 2021
hithwen
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the
validate license
command to add the ability for integrations to have 3rd party licenses which are not pulled directly from the requirements file and the origin is not PyPI.Motivation
#9786
Additional Notes
To test, add a
LICENSE-3rdparty-extra.csv
to the directory of any check. See #9786 for an example.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached