Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove required when there are default values #9475

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Remove required when there are default values #9475

merged 1 commit into from
Jun 4, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jun 4, 2021

There are in code default values for these

@hithwen hithwen requested review from a team as code owners June 4, 2021 15:32
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #9475 (2b1ebc5) into master (c3099da) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
yarn 90.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit d2adddb into master Jun 4, 2021
@ofek ofek deleted the js/fix-yarn-defaults branch June 4, 2021 16:40
ofek pushed a commit that referenced this pull request Jun 7, 2021
@hithwen @ofek
Remove required when there are default values (#9475)
f4e5b66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@coignetp coignetp coignetp approved these changes

@sarina-dd sarina-dd sarina-dd approved these changes

Assignees
No one assigned
Labels
documentation integration/yarn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hithwen @ofek @coignetp @sarina-dd