-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collect_aggregates_only
option type in example config
#9473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coignetp
commented
Jun 4, 2021
hithwen
previously approved these changes
Jun 4, 2021
hithwen
reviewed
Jun 4, 2021
4 tasks
coignetp
force-pushed
the
paul/fix-haproxy-model
branch
from
June 4, 2021 13:59
4117e03
to
a9cc169
Compare
sarina-dd
previously approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 docs change
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ofek
approved these changes
Jun 4, 2021
ofek
changed the title
Fix collect_aggregates_only option type
Fix Jun 4, 2021
collect_aggregates_only
option type in example config
ofek
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Fix collect_aggregates_only option type * Use anyOf * Sync spec and models * Sync models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
collect_aggregates_only
option can betrue
,false
, orboth
, so it's not a boolean.Motivation
QA #8924
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached