Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collect_aggregates_only option type in example config #9473

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Fix collect_aggregates_only option type in example config #9473

merged 4 commits into from
Jun 4, 2021

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jun 4, 2021

What does this PR do?

collect_aggregates_only option can be true, false, or both, so it's not a boolean.

Motivation

QA #8924

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from a team as code owners June 4, 2021 11:23
hithwen
hithwen previously approved these changes Jun 4, 2021
View reviewed changes
@coignetp coignetp mentioned this pull request Jun 4, 2021
Merged
4 tasks
sarina-dd
sarina-dd previously approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@sarina-dd sarina-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 docs change

@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #9473 (cefe68d) into master (c3099da) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
haproxy 95.22% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
haproxy/datadog_checks/haproxy/legacy/haproxy.py 92.23% <0.00%> (+0.44%) ⬆️

@ofek ofek merged commit 2149f20 into master Jun 4, 2021
@ofek ofek deleted the paul/fix-haproxy-model branch June 4, 2021 15:28
@ofek ofek changed the title Fix collect_aggregates_only option type Fix collect_aggregates_only option type in example config Jun 4, 2021
ofek pushed a commit that referenced this pull request Jun 7, 2021
@coignetp @ofek
Fix collect_aggregates_only option type (#9473)
d356312 
* Fix collect_aggregates_only option type

* Use anyOf

* Sync spec and models

* Sync models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen left review comments

@ofek ofek ofek approved these changes

@sarina-dd sarina-dd sarina-dd left review comments

Assignees
No one assigned
Labels
documentation integration/haproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coignetp @hithwen @ofek @sarina-dd