Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JMX config spec #9364

Merged
merged 1 commit into from
May 18, 2021
Merged

Fix JMX config spec #9364

merged 1 commit into from
May 18, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented May 17, 2021 •
edited
Loading

Motivation

collect_default_metrics is optional

need for #8985

@ofek ofek requested review from a team as code owners May 17, 2021 23:44
@codecov
Copy link

codecov bot commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #9364 (835b132) into master (2c6a9c5) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 80.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit 657c2e2 into master May 18, 2021
@ofek ofek deleted the ofek/jmx branch May 18, 2021 12:23
@ofek ofek mentioned this pull request May 18, 2021
Merged
daanleenders pushed a commit to daanleenders/integrations-core that referenced this pull request May 19, 2021
@ofek @daanleenders
Fix JMX config spec (DataDog#9364)
5c1173f
@ofek ofek mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/activemq integration/cassandra integration/confluent_platform integration/datadog_checks_dev integration/hazelcast integration/hive integration/hivemq integration/ignite integration/jboss_wildfly integration/kafka integration/presto integration/solr integration/sonarqube integration/tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @hithwen