Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError in AIA chasing #9328

Merged
merged 1 commit into from
May 11, 2021
Merged

Fix AttributeError in AIA chasing #9328

merged 1 commit into from
May 11, 2021

Conversation

FlorianVeaux
Copy link
Member

@FlorianVeaux FlorianVeaux commented May 11, 2021 •
edited
Loading

Otherwise the ExtensionNotFound is raised by the AttributeError call.

This will also make sure that the cant_connect service check is correctly emitted in case something goes wrong

@FlorianVeaux FlorianVeaux requested review from a team as code owners May 11, 2021 07:45
coignetp
coignetp approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@FlorianVeaux FlorianVeaux merged commit 820e7ea into master May 11, 2021
@FlorianVeaux FlorianVeaux deleted the flo/fix_aia_chasing_log branch May 11, 2021 08:41
FlorianVeaux added a commit that referenced this pull request May 11, 2021
@FlorianVeaux
Fix AttributeError in AIA chasing (#9328)
06812c4
sgnn7
sgnn7 reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the PR but LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgnn7 sgnn7 sgnn7 left review comments

@coignetp coignetp coignetp approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorianVeaux @sgnn7 @coignetp