KSM: add node.by_condition to have the conditions of individual nodes
#9311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clamoriniere
approved these changes
May 7, 2021
hithwen
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
kubernetes_state.node.by_conditionmetric to have the conditions of individual nodes.Motivation
The current
kubernetes_state.nodes.by_condition(with ans. Plural vs. singular) metric aggregates all nodes by condition.With this metric, we could know how many nodes were in a given condition, but not more precisely which ones.
The new metric allows to know precisely which nodes are in a given condition.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached