-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenMetricsV2] Add an option to send sum and count information when using distribution metrics #9301
Conversation
The I understand the Side note: this will cause merge conflicts with #9276 cc @gh123man |
@olivielpeau If we send one, we should send both imo to avoid confusion. The requests also desire both. WDYT? |
The main downside I can think of is that for openmetrics integrations that send metrics counted as custom metrics, this would send one more custom metric ( |
The customers in the linked issue consider both to be useful actually, so I think this is worth it |
Added a flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the code in details, but behavior LGTM :)
(the flag should probably be documented?)
Rebased to fix a bunch of ci jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I agree that it shouldn't be the default behavior as the count is duplicate info from what we already have in the distribution metric, but this could be useful for people who really want the accurate sum of values (although percentiles on the distribution metrics could be more useful in an alerting context)
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We're sending OpenTelemetry Histograms via a prometheus exporter to Datadog via the agent and the openmetrics check. We know the agent sends these to datadog as distributions, and are seeing very odd counts for these distributions. Does this issue sound familiar, is this PR meant to address this issue on histograms -> distributions -> accurate counts? TY. For ref, datadog support tickets 565850 and 567929 are related. |
Motivation
Resolves: