Change 'collision in cached query metrics' log from debug to error #9268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djova
previously approved these changes
Apr 29, 2021
luisgonzalex
approved these changes
Apr 29, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
luisgonzalex
deleted the
alex.normand/change-log-level-of-colliding-query-rows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With #9227 which performs a merge of rows by key, we should never see any colliding rows when computing derivative rows. Because of this, the log showing the detection of a collision would be much more serious and an indicator of a bug so this increases the logging from
debugtoerror.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached