Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka - Added session metrics #9183

Merged
merged 1 commit into from
May 4, 2021
Merged

Kafka - Added session metrics #9183

merged 1 commit into from
May 4, 2021

Conversation

DingGGu
Copy link
Contributor

@DingGGu DingGGu commented Apr 17, 2021

What does this PR do?

A new metric for the number of kafka sessions has been added.
This metric helps determine large scale of kafka parameters for max.incremental.fetch.session.cache.slots

Motivation

When using kafka with many consumers, some parameters need to optimize performance.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-227%3A+Introduce+Incremental+FetchRequests+to+Increase+Partition+Scalability

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@DingGGu DingGGu requested a review from a team as a code owner April 17, 2021 00:53
@DingGGu DingGGu marked this pull request as draft April 17, 2021 14:08
@DingGGu DingGGu changed the title Kafka Added session metrics Kafka - Added session metrics Apr 17, 2021
@hithwen hithwen merged commit 6e97ef6 into DataDog:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants