Skip slowlogs if there is an error #9147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -449,7 +449,8 @@ def _check_slowlog(self): | |||
|
|
|||
| # Get all slowlog entries | |||
|
|
|||
| slowlogs = conn.slowlog_get(max_slow_entries) | |||
| # https://github.com/andymccurdy/redis-py/issues/1238 | |||
| slowlogs = conn.slowlog_get(max_slow_entries, decode_responses=False) | |||
There was a problem hiding this comment.
Do you mean to use parse_slowlog_get? https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L401
Otherwise the param is num for slowlog_get: https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L1517-L1527
There was a problem hiding this comment.
Oh, yes, indeed, this methods uses the connection options, and 'decode_responses' is false by default https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L744.
It would also not help in any case since both options would produce the same result
>>> ' '.join([1, 2, 3])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: sequence item 0: expected str instance, int found
>>> b' '.join([1, 2, 3])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: sequence item 0: expected a bytes-like object, int found
In the linked issue the error is str found while here is int found
hithwen
changed the title
ChristineTChen
approved these changes
Apr 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #8716
Caused by redis/redis-py#1475