Add KubeletBase base class
#9051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celenechang
force-pushed
the
celene/add_base_kubelet
branch
from
6cbc135
to
e1ae6aa
Compare
ofek
requested changes
Mar 29, 2021
Comment on lines
7
to
8
| from datadog_checks.base import AgentCheck | ||
| from datadog_checks.base.utils.date import UTC, parse_rfc3339 |
There was a problem hiding this comment.
Let's use relative throughout:
Suggested change
| from datadog_checks.base import AgentCheck | |
| from datadog_checks.base.utils.date import UTC, parse_rfc3339 | |
| from ...utils.date import UTC, parse_rfc3339 | |
| from .. import AgentCheck |
| from datadog_checks.base.checks.kubelet_base.base import KubeletBase, urljoin | ||
| from datadog_checks.base.utils.date import UTC | ||
|
|
||
| HERE = os.path.abspath(os.path.dirname(__file__)) |
There was a problem hiding this comment.
| return f.read() | ||
|
|
||
|
|
||
| class MockStreamResponse: |
There was a problem hiding this comment.
Let's use #8276 e.g.
ofek
changed the title
KubeletBase base class
celenechang
force-pushed
the
celene/add_base_kubelet
branch
from
33136c0
to
2add9cf
Compare
ofek
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add kubelet_base in datadog_checks_base to be used for checks that need to access Kubelet
Motivation
Put shared code in a single place
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached