Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timeout for Kubernetes API calls #9035

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Add a timeout for Kubernetes API calls #9035

merged 1 commit into from
Mar 26, 2021

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Mar 25, 2021 •
edited
Loading

What does this PR do?

Add a timeout for Kubernetes API calls.

Motivation

Guarantee that checks cannot remain blocked forever, even in case of network issue blackholing all the packets.

Additional Notes

We add the _request_timeout parameter which is documented here.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@L3n41c L3n41c requested review from a team as code owners March 25, 2021 17:00
@L3n41c
Copy link
Member Author

L3n41c commented Mar 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

remeh
remeh approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nit but maybe for the next developer looking at this, it would be great to link to te API source since this is an undocumented parameter? Something like https://github.com/kubernetes-client/python/blob/b79ad6837b2f5326c7dad488a64eed7c3987e856/kubernetes/client/api/coordination_v1_api.py#L1092-L1095 ?
But LGTM!

@L3n41c L3n41c merged commit 7c3b72b into master Mar 26, 2021
@L3n41c L3n41c deleted the lenaic/timeout4k8s branch March 26, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remeh remeh remeh approved these changes

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@xornivore xornivore xornivore approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@L3n41c @remeh @FlorianVeaux @xornivore