Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime configuration validation #8990

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Add runtime configuration validation #8990

merged 2 commits into from
Jun 15, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 22, 2021

What does this PR do?

Adds config models from #8675

@ofek ofek requested a review from a team as a code owner March 22, 2021 17:45
@ofek ofek force-pushed the ofek/sync_config_models_statsd branch from be31f6a to da15381 Compare March 23, 2021 14:38
@ofek ofek changed the title Sync config models Add runtime configuration validation Mar 23, 2021
hithwen
hithwen requested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@hithwen hithwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • host is not required, defaults to localhost
  • port is not required, defaults to 8126

@ofek ofek force-pushed the ofek/sync_config_models_statsd branch from da15381 to dcfd5ac Compare June 14, 2021 21:06
@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #8990 (ab02a00) into master (04264d3) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
statsd 87.36% <ø> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek requested a review from a team as a code owner June 14, 2021 21:14
@ghost ghost added the documentation label Jun 14, 2021
kayayarai
kayayarai approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from docs

@ofek ofek merged commit a966967 into master Jun 15, 2021
@ofek ofek deleted the ofek/sync_config_models_statsd branch June 15, 2021 13:38
github-actions bot pushed a commit that referenced this pull request Jun 15, 2021
@ofek
Add runtime configuration validation (#8990)
3fe1eb9 
* Sync config models

* address a966967
alexandre-normand pushed a commit that referenced this pull request Jun 24, 2021
@ofek @alexandre-normand
Add runtime configuration validation (#8990)
8933e09 
* Sync config models

* address
@coignetp coignetp mentioned this pull request Jul 15, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

@kayayarai kayayarai kayayarai approved these changes

Assignees
No one assigned
Labels
documentation integration/statsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @hithwen @kayayarai