Improve orjson compatibility #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
* Fixes `AttributeError: module 'orjson' has no attribute 'JSONEncoder'` when importing `datadog_checks.base.utils.db.statement_samples` where `orjson` is installed. * Add `datadog_checks_base` `json` dependency to postgres tests so we're testing orjson correctly * Update statement sampler stub to serialize events to/from json to ensure we're testing the json serialization during integration tests.
djova
force-pushed
the
djova/postgres-fix-json
branch
from
900ff09
to
13f13d0
Compare
ofek
approved these changes
Mar 5, 2021
djova
added a commit
that referenced
this pull request
Mar 5, 2021
Bump to new version containing this fix: #8767
4 tasks
ofek
pushed a commit
that referenced
this pull request
Mar 5, 2021
Bump to new version containing this fix: #8767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AttributeError: module 'orjson' has no attribute 'JSONEncoder'when importingdatadog_checks.base.utils.db.statement_sampleswhereorjsonis installed.datadog_checks_basejsondependency to postgres tests so we're testing orjson correctlyMotivation
Fix broken import for DBM in case of
orjsondependency being installed.Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached