Shutdown statement sampler thread on cancel #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
olivielpeau
previously approved these changes
Mar 5, 2021
hush-hush
previously approved these changes
Mar 5, 2021
djova
force-pushed
the
djova/postgres-check-implement-cancel
branch
from
810dc0e
to
52c79c8
Compare
hush-hush
approved these changes
Mar 5, 2021
ofek
changed the title
ofek
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the cancel feature added in #8463 to ensure the statement sampler thread is stopped when the check is unscheduled.
Follow-up to #8627
Motivation
Faster resource cleanup when a check is unscheduled.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached