Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres check: bump datadog_checks_base min version #8757

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

djova
Copy link
Contributor

@djova djova commented Mar 4, 2021

What does this PR do?

Bump datadog_checks_base min version for the postgres check.

Follow-up to #8627

Depends on #8759

Motivation

Fix broken build due to old datadog_checks_base minimum version.

E   ImportError: cannot import name 'compute_exec_plan_signature' from 'datadog_checks.base.utils.db.sql' (/home/vsts/work/1/s/postgres/.tox/py38/lib/python3.8/site-packages/datadog_checks/base/utils/db/sql.py)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@djova djova requested a review from a team as a code owner March 4, 2021 18:57
@ghost ghost added the integration/postgres label Mar 4, 2021
@djova djova force-pushed the djova/postgres-bump-base branch 2 times, most recently from d1bcc5f to 7954f25 Compare March 4, 2021 19:46
ofek
ofek previously approved these changes Mar 4, 2021
Fix broken build due to old datadog_checks_base minimum version.

```
E   ImportError: cannot import name 'compute_exec_plan_signature' from 'datadog_checks.base.utils.db.sql' (/home/vsts/work/1/s/postgres/.tox/py38/lib/python3.8/site-packages/datadog_checks/base/utils/db/sql.py)
```

Follow-up to #8627

Depends on #8759
@ofek ofek merged commit 31d75d2 into master Mar 4, 2021
@ofek ofek deleted the djova/postgres-bump-base branch March 4, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants