-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect mysql statement samples & execution plans #8629
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
22eb694
Collect mysql statement samples & execution plans
djova a798846
style
djova 3b3955f
Update mysql/assets/configuration/spec.yaml
djova 330fb15
Update mysql/assets/configuration/spec.yaml
djova d4e95d7
Update mysql/assets/configuration/spec.yaml
djova f53d1f6
Update mysql/assets/configuration/spec.yaml
djova ab13a8e
Update mysql/assets/configuration/spec.yaml
djova 19632de
Update mysql/assets/configuration/spec.yaml
djova db07b89
Update mysql/assets/configuration/spec.yaml
djova 085e8d1
Update mysql/assets/configuration/spec.yaml
djova e05269a
Update mysql/assets/configuration/spec.yaml
djova d123996
Update mysql/assets/configuration/spec.yaml
djova e190b65
Update mysql/assets/configuration/spec.yaml
djova 130c199
Update mysql/assets/configuration/spec.yaml
djova 7c56f38
Update spec
djova 3c1522e
support cancel
djova 3223a70
Update mysql/assets/configuration/spec.yaml
djova b7babd8
Update mysql/assets/configuration/spec.yaml
djova 0e3657a
Update mysql/assets/configuration/spec.yaml
djova b9ea084
Update mysql/assets/configuration/spec.yaml
djova 4136105
Conf example update from spec
djova eac38ff
fix client race condition in tests
djova cbec27f
remove unnecessary
djova d8e1937
style
djova 4e144ca
use json dep
djova 37cd220
bump base
djova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olivielpeau @hush-hush I added support for
cancel
here. I think we should still keep the "stop thread if it notices the check is no longer running" logic as a fallback if the main check stops running for any other reason (agent overload, or a bug somewhere where it gets stuck).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, LGTM.
I don't have a strong opinion about the fallback. Just a couple of thoughts: if the check is stuck it'll cause other problems (it'll hog a check runner, etc), but the fallback would at least free up some resources that's true. If the check is inactive because of an agent overload, and the fallback mechanism stops the background thread, you'll want to make sure the background thread can be started up again cleanly when the check is run again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is the current behavior. On every check run the check will start up the thread if it is not currently running.