Rename cluster_name tag to spark_cluster #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
kayayarai
previously approved these changes
Feb 11, 2021
coignetp
previously approved these changes
Feb 16, 2021
hithwen
requested changes
Feb 16, 2021
spark/assets/configuration/spec.yaml
Outdated
Comment on lines
107
to
111
| - name: disable_legacy_cluster_tag | ||
| description: Enable to stop submitting the tag `cluster_name`, which has been renamed to `spark_cluster`. | ||
| value: | ||
| type: boolean | ||
| example: false |
There was a problem hiding this comment.
ChristineTChen
dismissed stale reviews from coignetp and kayayarai
via
9acbe62
coignetp
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a backwards compatible config option disable_legacy_cluster_tag which will stop sending cluster_name tag.
Motivation
cluster_name tag is also emitted at the hostlevel. Using a service specific tag key will prevent conflicts/confusion.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached