Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cluster_name tag to yarn_cluster #8579

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Rename cluster_name tag to yarn_cluster #8579

merged 3 commits into from
Feb 12, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

This PR introduces a backwards compatible config option disable_legacy_cluster_tag which will stop sending cluster_name tag.

Motivation

cluster_name tag is also emitted at the hostlevel. Using a service specific tag key will prevent conflicts/confusion.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners February 9, 2021 22:18
cswatt
cswatt reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review required 👍

@ChristineTChen ChristineTChen merged commit 008fb57 into master Feb 12, 2021
@ChristineTChen ChristineTChen deleted the cc/yarn-cluster branch February 12, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt left review comments

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
documentation integration/yarn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @cswatt @FlorianVeaux