Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing on KeyError #8563

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Avoid failing on KeyError #8563

merged 2 commits into from
Feb 9, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

This PR ensures that the check will not fail on KeyError when there is an empty list for app/node/queue.

Motivation

Resolves #8553

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner February 8, 2021 21:07
@ghost ghost added the integration/yarn label Feb 8, 2021
mgarabed
mgarabed previously approved these changes Feb 8, 2021
@ChristineTChen
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

yarn/datadog_checks/yarn/yarn.py Show resolved Hide resolved
yarn/datadog_checks/yarn/yarn.py Show resolved Hide resolved
yarn/datadog_checks/yarn/yarn.py Show resolved Hide resolved
ofek
ofek previously approved these changes Feb 8, 2021
@ChristineTChen ChristineTChen merged commit f04a91c into master Feb 9, 2021
@ChristineTChen ChristineTChen deleted the cc/yarn-bugfix branch February 9, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn integration throws error on zero applications
3 participants