Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prometheus summary quantile metrics #8488

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Fix Prometheus summary quantile metrics #8488

merged 4 commits into from
Jan 29, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Found bug during QA. Remapped summary metrics are not submitting quantile metrics.

In V2, the following config only yields 15 metrics because openmetrics.target_interval_seconds.quantile were not being submitted.

init_config: {}
instances:
- metrics:
  - prometheus_target_interval_length_seconds: target_interval_seconds
  - prometheus_http_request_duration_seconds: http_req_duration_seconds
  - go_memstats_mallocs_total
  - go_memstats_alloc_bytes
  namespace: openmetrics
  openmetrics_endpoint: http://localhost:9090/metrics

@ChristineTChen ChristineTChen requested review from a team as code owners January 28, 2021 18:16
ofek
ofek previously approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek ofek merged commit 8c16b08 into master Jan 29, 2021
@ofek ofek deleted the cc/openmetrics-quantik branch January 29, 2021 03:55
ofek pushed a commit that referenced this pull request Jan 29, 2021
@ChristineTChen @ofek
Fix Prometheus summary quantile metrics (#8488)
f9abede 
* Fix summary quantile metrics

* Add test

* Fix tags

* Fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristineTChen @ofek