Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pyyaml in datadog_checks_dev #8400

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Pin pyyaml in datadog_checks_dev #8400

merged 3 commits into from
Jan 20, 2021

Conversation

florimondmanca
Copy link
Contributor

What does this PR do?

Motivation

Docs CI builds are currently broken due to yaml/pyyaml#478
I proposed to help there, but let's pin here until the issue gets fixed so contributors aren't confused.

Additional Notes

Note that's we're already properly pinned in the base package, so not a problem for the upcoming Agent release.

integrations-core/datadog_checks_base/requirements.in

Line 18 in 8c8c8a6

pyyaml==5.3.1

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested a review from a team as a code owner January 20, 2021 16:29
ofek
ofek previously approved these changes Jan 20, 2021
View reviewed changes
@florimondmanca
Copy link
Contributor Author

florimondmanca commented Jan 20, 2021 •
edited
Loading

I'm confused, I'm still seeing the error and yet logs indicate that pyyaml==5.3.1 was installed. Attempting a different approach using pip install --no-binary=pyyaml ..., since what seems to be causing issues is the interaction with PyYAML's C-optimized code.

Edit: OK, found it. datadog_checks_dev had a PyYAML>=5.3 requirement that was probably overriding anything I could put in the docs tox.ini.

@florimondmanca florimondmanca changed the title Pin pyyaml in docs build Pin pyyaml in datadog_checks_dev Jan 20, 2021
@florimondmanca florimondmanca merged commit c736e74 into master Jan 20, 2021
@florimondmanca florimondmanca deleted the fm/docs-yaml-pin branch January 20, 2021 17:07
github-actions bot pushed a commit that referenced this pull request Jan 20, 2021
@florimondmanca
Pin pyyaml in datadog_checks_dev (#8400)
97b251f 
* Pin pyyaml in docs build

* Try --no-binary

* Apply pin in datadog_checks_dev deps c736e74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek left review comments

Assignees
No one assigned
Labels
changelog/no-changelog integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @ofek