-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor replica metrics and add some debug lines #8380
Conversation
f7470ac
to
b1ea437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic and diff looks good, tests were not modified and they pass… LGTM :)
is_mariadb = self.version.flavor == "MariaDB" | ||
replication_channel = options.get('replication_channel') | ||
if replication_channel: | ||
self.service_check_tags.append("channel:{0}".format(replication_channel)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this operation was ported in this new version. I assume that's because we do tags + service_check_tags
when submitting service checks, so channel
is still submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, now config.tags
has channel from the beginning so service_check_tags
gets it when built. But I've realised I might be duplicating that tag in other places where we're still composing, I'll check & update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, seems the only place was https://github.com/DataDog/integrations-core/pull/8380/files#diff-4ecc52a59650f90cba9b1b1b3a145f8dc3457d133fc52419846c63e62bbe9bd8R389 and we are ensuring tags are unique there
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Factor replica metrics and service check into its own methods and added more debug lines. Also stopped passing down params that are accessible through self. And put whole tag calculation on the config object creation