Refactor replica metrics and add some debug lines #8380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hithwen
force-pushed
the
julia/AGENT-5566-refactor-and-logs
branch
from
f7470ac
to
b1ea437
Compare
florimondmanca
approved these changes
Jan 19, 2021
| is_mariadb = self.version.flavor == "MariaDB" | ||
| replication_channel = options.get('replication_channel') | ||
| if replication_channel: | ||
| self.service_check_tags.append("channel:{0}".format(replication_channel)) |
There was a problem hiding this comment.
I don't think this operation was ported in this new version. I assume that's because we do tags + service_check_tags when submitting service checks, so channel is still submitted.
There was a problem hiding this comment.
Exactly, now config.tags has channel from the beginning so service_check_tags gets it when built. But I've realised I might be duplicating that tag in other places where we're still composing, I'll check & update
There was a problem hiding this comment.
No, seems the only place was https://github.com/DataDog/integrations-core/pull/8380/files#diff-4ecc52a59650f90cba9b1b1b3a145f8dc3457d133fc52419846c63e62bbe9bd8R389 and we are ensuring tags are unique there
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor replica metrics and service check into its own methods and added more debug lines. Also stopped passing down params that are accessible through self. And put whole tag calculation on the config object creation