Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device_label tag in addition to label tag. #8306

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jan 7, 2021

What does this PR do?

This makes labels a bit more consistent with agent's builtin io check, which uses device_label. When this is merged, users will be able to consistently use device_label tag for metrics from both of these checks.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

This makes labels a bit more consistent with agent's builtin io check,
which uses device_label.
@bkabrda bkabrda requested review from a team as code owners January 7, 2021 13:29
@ghost ghost added the integration/disk label Jan 7, 2021
@bkabrda
Copy link
Contributor Author

bkabrda commented Jan 7, 2021

Thanks for the reviews! Merging.

@bkabrda bkabrda merged commit e3368b3 into master Jan 7, 2021
@bkabrda bkabrda deleted the slavek.kabrda/disk-add-device-label-tag branch January 7, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants